Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-15324 override ephemeral post example #312

Closed
wants to merge 1 commit into from
Closed

MM-15324 override ephemeral post example #312

wants to merge 1 commit into from

Conversation

scottleedavis
Copy link
Contributor

@marianunez
Copy link
Member

Does adding this ephemeral override post example here needed? I feel that with the basic post override example and what was added with this PR that is reflected in the detailed Registry section of this same document would be enough. 1/5
Thoughts? @lieut-data

Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think there's value in testing this, though as I note below, we should wire it up to the server-side of the plugin to actually use it. QA uses the demo plugin to verify functionality, and having this ready-to-go will enable trivial verification.

@scottleedavis
Copy link
Contributor Author

Thank you both again for your time.

@marianunez marianunez removed their request for review July 26, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Dev Review Requires review by a core commiter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants