When the user account is deactivated, direct message channels are not updated with deleted time

[Vars-07]

Summary

When the user account is deactivated, direct message channels are not updated with deleted time

Steps to reproduce

How can we reproduce the issue (what version are you using?)

1. Go to any deactivate account for the user.
2. Notice that for that user the deactivate account channel response returned from API does not have deleted_at value, even though that account is deleted.

Expected behavior

Describe your issue in detail
Once the user account is deactivated, deleted_at must be updated for all DM channels having one account as deactivated user account.

Observed behavior (that appears unintentional)

What did you see happen? Please include relevant error messages and/or screenshots.
API for that direct message channel is not returning correct result, i.e, delete information for that direct channel is not getting updated.

Possible fixes

If you can, link to the line of code that might be responsible for the problem
when the account is deactivated, all direct channels corresponding to that account needs to be updated with delete information

[Vars-07]

Will pick it up.

[jgilliam17]

Thank you @Vars-07
Jira issue: https://mattermost.atlassian.net/browse/MM-26941

[roshanjrajan]

Could I try and take a shot at this if this is still open?

[roshanjrajan]

Just writing down my thoughts.

Webapp/Redux change that allows a switch to the previous channel that was last open including Direct Channels. This has been merged.

Server Side there is a change so that when the Updating the User's state (UpdateActive), the code path currently attempts to Delete each channel instead of purely setting the Delete TimeStamp. Unwanted side-effect is that DMs are deleted on updates to the UI instead of left to the user to be removed.

Goal is to purely set the delete timestamp and leave removal of UI elements to user. Possibly use the SetDeleteAt function instead? Need to investigate.