Updated the deleted_at timestamp for deactivated direct message channel

[Vars-07]

Summary

When the user account is deactivated, direct message channels are not updated with deleted time

Ticket Link

https://mattermost.atlassian.net/browse/MM-26941

[hanzei]

/update-branch

[hanzei]

Hi @Vars-07,

Thanks for the PR 👍 Could you please run make store-layers and commit the changes to fix the CI error?

[Vars-07]

@hanzei Updated. Have a look :)

[agnivade]

Thanks for working on this @Vars-07 ! I have some comments to improve this further.

[ashishbhate]

Looks good @Vars-07 ! Some small suggestions inline.

[agnivade]

@jgilliam17 - Assigning to you since you filed the original issue and have a general context. The overall behavior is tested with unit tests.

[jgilliam17]

Thank you @Vars-07

I am seeing a deactivated DM removed from the LHS as another channel/DM is opened, without having to close deactivated DM. Deactivated DMs should remain on the LHS even when not open on the main channel view.
Let me know if this change is related to this fix. If not, I can file separately.
If you look at the images, on the old sidebar deactivated DM is present when open, on exp. sidebar DM is not shown on the LHS. When switching away to a different channel, on both old and exp sidebar, deactivated DM should still be present on the LHS.

Old sidebar	Exp. Sidebar

[Vars-07]

Hi, @jgilliam17, yes that change of vanishing away archived/deactivated channel is not related to this fix. IMO that should be UI issue. you can file a separate Jira for that. Thanks

[jgilliam17]

/update-branch

[hmhealey]

@Vars-07 Can you explain again what problem you were having with DMs not being deleted when one of their members is deactivated? I'm not sure if marking the DM as deleted is the correct way to fix that since deleting DMs might have unintended side effects such as the one @jgilliam17 reported. In the past, we've assumed that DMs and GMs are only hidden, never archived, so I'd be worried about changing that now

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich

[jasonblais]

Hi @Vars-07, let us know if you had thoughts or questions on Harrison's latest message. Would be happy to clarify :)

From @hmhealey:

@Vars-07 Can you explain again what problem you were having with DMs not being deleted when one of their members is deactivated? I'm not sure if marking the DM as deleted is the correct way to fix that since deleting DMs might have unintended side effects such as the one @jgilliam17 reported. In the past, we've assumed that DMs and GMs are only hidden, never archived, so I'd be worried about changing that now

[stylianosrigas]

Removing the test server for maintenance purposes. Please add the label again if you need it. Sorry for any inconvenience.

[mm-cloud-bot]

Test server destroyed

[hanzei]

@Vars-07 Do you have any questions about the feedback?
Please note that we will close this PR after another 10 days of inactivity. If you don't object, other contributors might complete this PR for you.

[Vars-07]

Hey, Sorry for the delay, was little occupied will pick it up asap. Thanks

…

On Tue, Sep 22, 2020, 18:00 Ben Schumacher ***@***.***> wrote: @Vars-07 <https://github.com/Vars-07> Do you have any questions about the feedback <#15039 (comment)> ? Please note that we will close this PR after another 10 days of inactivity. If you don't object, other contributors might complete this PR for you. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15039 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AES3HDA4F5HM22AJTKAAVTDSHCKFNANCNFSM4O2VPQNA> .

[jgilliam17]

Removing my name but, leaving the QA review label. Please add me again when PR is ready for re-review. Thanks.

[jasonblais]

Big thanks for your contribution!

However, it has been some time with no activity so we've marked your PR as inactive. Per our inactive contribution process, it is eligible to be assumed by another community member interested in working on the ticket.

If there are any areas we can help clarify or provide guidance, let us know! We'd be happy to help :)