Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove restriction that SMTP auth requires TLS #2929

Closed
gramakri opened this issue May 9, 2016 · 3 comments
Closed

Remove restriction that SMTP auth requires TLS #2929

gramakri opened this issue May 9, 2016 · 3 comments

Comments

@gramakri
Copy link
Contributor

gramakri commented May 9, 2016

mattermost does not set auth if TLS/Starttls is disabled. It was mentioned in #187 that this is a Go library limitation.

I am wondering if this is indeed the case. There was a discussion about this in https://groups.google.com/forum/#!topic/golang-nuts/VjJC2BjmU2E and it resulted in golang/go@ca24f9e.
@gramakri
Copy link
Contributor Author

gramakri commented May 9, 2016

For context, on the Cloudron, we use a local mail server with auth. This doesn't work well with mattermost because of the tls restriction. In addition. mattermost also requires a valid cert (a self-signed doesn't seem to suffice).

@gramakri gramakri mentioned this issue May 9, 2016
Closed
gramakri added a commit to cloudron-io/mattermost that referenced this issue May 10, 2016
@gramakri
mail: allow PLAIN auth over non-tls connections
0475805 
This allows mattermost to use a non-tls connection with a SMTP server that
supports PLAIN auth (but not LOGIN). The go library explicitly allows PLAIN
auth over non-tls connections - https://golang.org/src/net/smtp/auth.go#L55

Fixes mattermost#2929
@lfbrock
Copy link
Contributor

lfbrock commented May 19, 2016

Thanks @gramakri - Closing this issue, and we will accept the PR after the small changes are made.

@lfbrock lfbrock closed this as completed May 19, 2016
@gramakri
Copy link
Contributor Author

@lfbrock I have been tied with other things now :-( I will get to this, thanks for the feedback.

gramakri added a commit to cloudron-io/mattermost that referenced this issue Jul 20, 2016
@gramakri
mail: allow PLAIN auth over non-tls connections
37b9d4d 
This allows mattermost to use a non-tls connection with a SMTP server that
supports PLAIN auth (but not LOGIN). The go library explicitly allows PLAIN
auth over non-tls connections - https://golang.org/src/net/smtp/auth.go#L55

Fixes mattermost#2929
gramakri added a commit to cloudron-io/mattermost that referenced this issue Aug 29, 2016
@gramakri
mail: allow PLAIN auth over non-tls connections
a9483ad 
This allows mattermost to use a non-tls connection with a SMTP server that
supports PLAIN auth (but not LOGIN). The go library explicitly allows PLAIN
auth over non-tls connections - https://golang.org/src/net/smtp/auth.go#L55

Fixes mattermost#2929
@gramakri gramakri mentioned this issue Aug 29, 2016
Merged
1 task
jwilander pushed a commit that referenced this issue Sep 2, 2016
@gramakri @jwilander
mail: allow PLAIN auth over non-tls connections (#3900)
6c08559 
This allows mattermost to use a non-tls connection with a SMTP server that
supports PLAIN auth (but not LOGIN). The go library explicitly allows PLAIN
auth over non-tls connections - https://golang.org/src/net/smtp/auth.go#L55

Fixes #2929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gramakri @lfbrock