Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain should not have '.' restrictions #61

Closed
poelzi opened this issue Jun 24, 2015 · 7 comments
Closed

Domain should not have '.' restrictions #61

poelzi opened this issue Jun 24, 2015 · 7 comments
Assignees
Milestone

Comments

@poelzi
Copy link

poelzi commented Jun 24, 2015

There seems to be very hard restrictions how many '.' are allowed in the domain which will always cause problems.

for testing I setup a instance:
dev.example.com, with www.dev.example.com and some other aliases.

when creating the team, the url is configured as
[INPUT] .dev.example

Also the redirect is then to the cut domain. Some TLD only allow second level domains. example.co.uk, also causing problem when running the service as a subdomain.

@it33
Copy link
Contributor

it33 commented Jun 24, 2015

If you're running locally as a developer then the system will work with just localhost or dockerhost if mapped in your /etc/hosts file. If you deployed via beanstalk then for now you must have a valid domain that is accessed via www.mydomain.com. Currently you cannot have sub-sub-domains so stuff like www.corp.mydomain.com will not work. It's a known issue we're working on to fix.

@acaranta
Copy link

I agree ... to first test this amazing product, and/or to use it internally it won't be used on a "root" domain but instead on a sub/sub domain, with a wildcard .... therefore the DNS restrictions are not really compatible currently ;)

I would prefer if mattermost could only use the first left part as the "wildcard" DNS part ;)

@wedtm
Copy link

wedtm commented Jun 24, 2015

It appears that TLD's longer than 3 characters are also invalid. I tried example.ninja and when going to the main URL, and trying to create a team, it redirects me to www.ninja

@coreyhulen
Copy link
Contributor

Our plan is to make it work with any number of sub-sub-domains. This is a known limitation that we plan to address soon. Currently, you must have a domain that looks like sub.domain.tld or *.example.com. The system also has a special case when it sees the host as localhost or dockerhost it will work in a developer/tester mode.

@wedtm there shouldn't be any limitation of only allowing 3 characters on the tld. You should access the site at www.example.ninja then once you create a team you can access the team directly at myteamname.example.ninja.

@devopsbrett
Copy link

I've just submitted a pull request with the changes I needed to make in order to support sub-sub domains. Even if not merged, it may still serve as a template to make your own modifications to get working sub-sub-domains #105

@faebser
Copy link

faebser commented Jul 2, 2015

+1
Also please make the all the domain related stuff configurable and work with sane defaults ( ex: no subdomains for teams).

@it33 it33 changed the title domain name has '.' restrictions Domain should not have '.' restrictions Jul 3, 2015
@it33 it33 added this to the 0.6.0 milestone Jul 3, 2015
@it33 it33 added the bug label Jul 3, 2015
@crspeller
Copy link
Member

#200 Will fix this.

@crspeller crspeller self-assigned this Jul 17, 2015
hanzei pushed a commit that referenced this issue Jul 13, 2023
* Set defaults on API Config

* Fix lint
hanzei pushed a commit that referenced this issue Jul 13, 2023
hanzei pushed a commit that referenced this issue Jul 13, 2023
* Revert "[GH-14939] Set defaults on API Config (#61)"

This reverts commit c4a03ec

* scheduleOnce; testing; wip with tracing statements and retry after failing

* remove tracing; cleanup

* refactoring; remove callback's error for simplicity; more tests

* improve test stability

* make api simpler; more tests

* linting

* refactor; more tests

* simplify naming

* simplify; turn startup into one call; only one callback allowed

* Un-simplify. The multi-step setup is needed.

* only one callback supported

* improve tests

* improve example

* closeHoldingMutex -> closeWhileHoldingMutex

* PR comments

* PR comments

* clarify comments

* update comments

* PR Comments; Close -> Cancel

* the linter bails on bad spelling? srsly?

Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
yasuaki-nakayama added a commit to findex-inc/remotalk-cloud that referenced this issue May 20, 2024
更新する箇所を間違えていたので修正
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants