Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-14727] Modified App.Bot.CreateBot to create a new post to the bot… #11062

Merged
merged 3 commits into from Jun 13, 2019

Conversation

Wipeout55
Copy link
Contributor

@Wipeout55 Wipeout55 commented Jun 6, 2019

…'s creator that allows the creator to add the bot to a team and a channel

Summary

Server-side portion of MM-14727.
This modifies the CreateBot() function such that once a bot is created, it's owner will receive a DM from the bot prompting the user to add the bot to a team and channel.

Ticket Link

Ref #10683

…'s creator that allows the creator to add the bot to a team and a channel
@Wipeout55 Wipeout55 marked this pull request as ready for review June 6, 2019 06:31
@jasonblais jasonblais added the 2: Dev Review Requires review by a developer label Jun 6, 2019
@hmhealey hmhealey requested review from jwilander and removed request for hmhealey June 6, 2019 18:45
Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one comment

app/bot.go Outdated Show resolved Hide resolved
@crspeller crspeller added Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) and removed 2: Dev Review Requires review by a developer labels Jun 11, 2019
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Jun 12, 2019
@hanzei
Copy link
Contributor

hanzei commented Jun 12, 2019

Should the server PR be merged first or the web app PR? Per mattermost/mattermost-webapp#2918 (comment) it should be the server one.

@Wipeout55
Copy link
Contributor Author

@hanzei You are correct, the server PR should be merged first.

@hanzei hanzei removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Jun 13, 2019
@hanzei hanzei merged commit c524ee5 into mattermost:master Jun 13, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jun 13, 2019
@amyblais amyblais added this to the v5.14.0 milestone Jun 13, 2019
@amyblais amyblais removed Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jun 13, 2019
Inconnu08 pushed a commit to Inconnu08/mattermost-server that referenced this pull request Jun 21, 2019
@amyblais amyblais removed this from the v5.14.0 milestone Sep 24, 2019
@hanzei hanzei added this to the v5.14.0 milestone Oct 7, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants