New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-14727] Modified App.Bot.CreateBot to create a new post to the bot… #11062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wipeout55
force-pushed
the
MM-14727
branch
3 times, most recently
from
June 6, 2019 05:35
2b059c0
to
79dbf7d
Compare
…'s creator that allows the creator to add the bot to a team and a channel
jwilander
requested changes
Jun 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one comment
jwilander
approved these changes
Jun 11, 2019
crspeller
approved these changes
Jun 11, 2019
crspeller
added
Do Not Merge/Awaiting PR
Awaiting another pull request before merging (e.g. server changes)
and removed
2: Dev Review
Requires review by a developer
labels
Jun 11, 2019
hanzei
added
the
4: Reviews Complete
All reviewers have approved the pull request
label
Jun 12, 2019
Should the server PR be merged first or the web app PR? Per mattermost/mattermost-webapp#2918 (comment) it should be the server one. |
@hanzei You are correct, the server PR should be merged first. |
hanzei
removed
the
Do Not Merge/Awaiting PR
Awaiting another pull request before merging (e.g. server changes)
label
Jun 13, 2019
amyblais
added
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
labels
Jun 13, 2019
amyblais
removed
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
labels
Jun 13, 2019
Inconnu08
pushed a commit
to Inconnu08/mattermost-server
that referenced
this pull request
Jun 21, 2019
amyblais
added
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
labels
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4: Reviews Complete
All reviewers have approved the pull request
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…'s creator that allows the creator to add the bot to a team and a channel
Summary
Server-side portion of MM-14727.
This modifies the CreateBot() function such that once a bot is created, it's owner will receive a DM from the bot prompting the user to add the bot to a team and channel.
Ticket Link
Ref #10683