Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky TestDoOutgoingWebhookRequest/with_a_slow_response #11712

Merged
merged 2 commits into from Jul 31, 2019
Merged

fix flaky TestDoOutgoingWebhookRequest/with_a_slow_response #11712

merged 2 commits into from Jul 31, 2019

Conversation

lieut-data
Copy link
Member

Summary

Avoid relying on time.Sleep to assert timeout behaviour.

Ticket Link

https://mattermost.atlassian.net/browse/MM-17314

@lieut-data
fix flaky TestDoOutgoingWebhookRequest/with_a_slow_response
29cf804 
Avoid relying on `time.Sleep` to assert timeout behaviour.
@lieut-data lieut-data added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Jul 25, 2019
@lieut-data lieut-data added this to the v5.14.0 milestone Jul 25, 2019
levb
levb reviewed Jul 25, 2019
View reviewed changes
app/webhook_test.go

server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
time.Sleep(timeout + time.Millisecond)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lindalumitchell lindalumitchell removed the 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review label Jul 26, 2019
@lindalumitchell lindalumitchell removed the request for review from prapti July 26, 2019 19:12
@lieut-data lieut-data added 4: Reviews Complete All reviewers have approved the pull request CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed 2: Dev Review Requires review by a developer labels Jul 31, 2019
@lieut-data lieut-data merged commit 53cae67 into master Jul 31, 2019
@lieut-data lieut-data deleted the MM-17314-fix-flaky-webhook-request-slow-response branch July 31, 2019 17:25
@mattermost-build mattermost-build mentioned this pull request Jul 31, 2019
Merged
@mattermod mattermod added AutomatedCherryPick and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jul 31, 2019
lieut-data pushed a commit that referenced this pull request Aug 1, 2019
@mattermost-build @lieut-data
Automated cherry pick of #11712 (#11757)
dc79ff4 
Avoid relying on `time.Sleep` to assert timeout behaviour.
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Aug 5, 2019
@prapti prapti added the Tests/Not Needed New release tests not required label Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levb levb levb left review comments

@deanwhillier deanwhillier deanwhillier approved these changes

@hmhealey hmhealey hmhealey approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request AutomatedCherryPick Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed New release tests not required
Projects
None yet
Milestone
v5.14.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@lieut-data @levb @deanwhillier @hmhealey @prapti @mattermod @lindalumitchell @amyblais