Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused struct fields #12924

Merged
merged 1 commit into from Oct 28, 2019
Merged

Remove unused struct fields #12924

merged 1 commit into from Oct 28, 2019

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Oct 25, 2019

Summary

This PR removes unused struct fields. There where found via structcheck. Fixing this issue is part of the afford to fix all problems found by golangci-lint.

Ticket Link

Follow up on #12909

@hanzei hanzei added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Oct 25, 2019
@hanzei hanzei removed the 2: Dev Review Requires review by a developer label Oct 26, 2019
@ogi-m ogi-m added QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process) and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Oct 28, 2019
@hanzei hanzei self-assigned this Oct 28, 2019
@hanzei hanzei added this to the v5.18.0 milestone Oct 28, 2019
@hanzei hanzei merged commit 71d5f7d into master Oct 28, 2019
@hanzei hanzei deleted the structcheck branch October 28, 2019 17:04
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 28, 2019
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Dec 11, 2019
@hanzei hanzei removed their assignment Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants