Cleanup dead code #12929
Merged
Cleanup dead code #12929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
2: Dev Review
hanzei
commented
Oct 25, 2019
| @@ -65,92 +65,6 @@ func (api *API) InitFile() { | |||
|
|
|||
| } | |||
|
|
|||
| func uploadFile(c *Context, w http.ResponseWriter, r *http.Request) { | |||
There was a problem hiding this comment.
This got replaced by uploadFileStream
hanzei
commented
Oct 25, 2019
| @@ -213,7 +213,7 @@ func testOAuthStoreRemoveAccessData(t *testing.T, ss store.Store) { | |||
| require.Nil(t, result, "did not delete access token") | |||
| } | |||
|
|
|||
| func testOAuthStoreRemoveAllAccessData(t *testing.T, ss store.Store) { | |||
| func TestOAuthStoreRemoveAllAccessData(t *testing.T, ss store.Store) { | |||
There was a problem hiding this comment.
This test was never run 😄
streamer45
approved these changes
Oct 26, 2019
iomodo
approved these changes
Oct 26, 2019
ogi-m
approved these changes
Oct 28, 2019
ogi-m
added
QA/Review Done
hanzei
added
the
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes dead code. There where found via
deadcode. Fixing this issue is part of the afford to fix all problems found bygolangci-lint.Ticket Link
Follow up on #12909