Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-33826] add more detailed S3 error messages #17182

Merged
merged 5 commits into from
Apr 9, 2021
Merged

[MM-33826] add more detailed S3 error messages #17182

merged 5 commits into from
Apr 9, 2021

Conversation

maxerenberg
Copy link
Contributor

Summary

This PR adds more details error messages when an S3 connection test fails in the system console.

Ticket Link

https://mattermost.atlassian.net/browse/MM-33826
https://mattermost.atlassian.net/browse/MM-32679

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 18, 2021
@maxerenberg maxerenberg added the 2: Dev Review Requires review by a developer label Mar 18, 2021
@maxerenberg
Copy link
Contributor Author

Here are some screenshots of the new sysconsole error messages:
Bucket does not exist
Screen Shot 2021-03-18 at 1 03 04 PM
Invalid S3 credentials
Screen Shot 2021-03-18 at 1 16 45 PM

mkraft
mkraft reviewed Mar 29, 2021
View reviewed changes
app/server.go Show resolved Hide resolved
shared/filestore/s3store.go Show resolved Hide resolved
shared/filestore/s3store.go Show resolved Hide resolved
@maxerenberg maxerenberg requested a review from mkraft March 30, 2021 19:45
@maxerenberg maxerenberg added the 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review label Apr 6, 2021
@furqanmlk furqanmlk added the Setup Cloud Test Server Setup an on-prem test server label Apr 9, 2021
furqanmlk
furqanmlk approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

@maxerenberg
Copy link
Contributor Author

/update-branch

@maxerenberg maxerenberg added the AutoMerge Used by Mattermod to merge PR automatically label Apr 9, 2021
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@mattermod
Copy link
Contributor

Trying to auto merge this PR.

@mattermod mattermod merged commit 3a3ec00 into master Apr 9, 2021
@mattermod
Copy link
Contributor

Pull Request successfully merged
SHA: 3a3ec00

@mattermod mattermod deleted the MM-33826_Add_S3_Error_Message_To_UI branch April 9, 2021 16:16
@mattermod mattermod removed AutoMerge Used by Mattermod to merge PR automatically Setup Cloud Test Server Setup an on-prem test server labels Apr 9, 2021
@mm-cloud-bot
Copy link

Test server destroyed

1 similar comment
@mm-cloud-bot
Copy link

Test server destroyed

@amyblais amyblais added this to the v5.35.0 milestone Apr 9, 2021
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation and removed 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Apr 9, 2021
mgdelacroix pushed a commit that referenced this pull request Apr 18, 2021
@mgdelacroix
[MM-33826] add more detailed S3 error messages (#17182)
1ddf59b 
Automatic Merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkraft mkraft mkraft approved these changes

@furqanmlk furqanmlk furqanmlk approved these changes

@sbishel sbishel sbishel approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
v5.35.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@maxerenberg @mattermod @mm-cloud-bot @mkraft @furqanmlk @sbishel @amyblais