Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sales-serve billing scheme #18697

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Added sales-serve billing scheme #18697

merged 2 commits into from
Oct 19, 2021

Conversation

marianunez
Copy link
Member

@marianunez marianunez commented Oct 15, 2021

Summary

Added new sales_serve BillingScheme for the price of cloud products that won't be able to be purchased self-served.

Ticket Link

https://mattermost.atlassian.net/browse/MM-39294

Related Pull Requests

Webapp: mattermost/mattermost-webapp#9151

Release Note

NONE

@mm-cloud-bot
Copy link

@marianunez: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

Copy link
Contributor

@nickmisasi nickmisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model/cloud.go Outdated Show resolved Hide resolved
Copy link
Contributor

@neallred neallred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, although I 👍 @nickmisasi 's idea for sales serve as a name.

Copy link
Contributor

@pvev pvev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with Nick's comment.

@marianunez marianunez changed the title Added internal billing scheme Added sales-serve billing scheme Oct 15, 2021
@marianunez marianunez added 4: Reviews Complete All reviewers have approved the pull request QA/Deferred Agreement with QA that these changes will be tested post-merge and removed 2: Dev Review Requires review by a developer labels Oct 15, 2021
@marianunez
Copy link
Member Author

This will be tested as part of mattermost/mattermost-webapp#9151

@marianunez marianunez added Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) and removed Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) labels Oct 15, 2021
@marianunez marianunez merged commit c75058d into master Oct 19, 2021
@marianunez marianunez deleted the internal-billing-price branch October 19, 2021 20:04
@marianunez marianunez added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Oct 19, 2021
@marianunez
Copy link
Member Author

/cherry-pick cloud

@mattermod
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/mattermost that referenced this pull request Oct 19, 2021
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 19, 2021
marianunez added a commit that referenced this pull request Oct 19, 2021
Co-authored-by: Maria A Nunez <maria.nunez@mattermost.com>
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 19, 2021
FreedomBen pushed a commit to FreedomBen/mattermost-server that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA/Deferred Agreement with QA that these changes will be tested post-merge release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants