check longtext data type for json types in mariadb

[isacikgoz]

Summary

Fixes migration check fail for JSON types against MariaDB databases.

Release Note

Fixed an issue where migration check failed for MariaDB databases. The data type JSON is aliased to LONGTEXT and the check was failing and causing the db migrations to run every restart.

[amyblais]

@isacikgoz Can you help resubmit this to the master branch, and then it can be cherry-picked to cloud and 6.0 branches?
@streamer45 Can you help prioritize PR review? I'd like to cut RC-1 today for 6.0.1.

[isacikgoz]

@amyblais we don't have migration checks for master branch. These checks are only on cloud branch.

[amyblais]

@isacikgoz Thanks, so this fix is not needed for 6.0.1?

[isacikgoz]

@amyblais It is needed for that one as well. The release branches and 6.0.1 are based on cloud branch IIRC. I'm going to do open a PR for release branch as well.

[mattermod]

Cherry pick is scheduled.

[mattermod]

Error trying doing the automated Cherry picking. Please do this manually

+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '140.82.112.4' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-server
 * [new branch]          MM-38445-dont-always-set-isfollowing-false -> upstream/MM-38445-dont-always-set-isfollowing-false
   5bbcfbd5f..4b68def82  MM-39053               -> upstream/MM-39053
 * [new branch]          ci-updates             -> upstream/ci-updates
   6ed1208a2..bb3ac887e  cloud                  -> upstream/cloud
   4f09fd7fe..8310805d8  crossTeamAuto          -> upstream/crossTeamAuto
   af8ce7fb6..e12fe3f30  custom_groups          -> upstream/custom_groups
   f7eef2cf4..a0f1b9290  internal-billing-price -> upstream/internal-billing-price
   ba3a911c9..fc712f5fd  master                 -> upstream/master
 * [new branch]          pre-package-playbooks-1.20.2 -> upstream/pre-package-playbooks-1.20.2
 * [new branch]          raceTest               -> upstream/raceTest
   2f394a1e5..aa1c03c27  release-6.0            -> upstream/release-6.0
Fetching origin
Failed to add the RSA host key for IP address '140.82.112.4' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-server-#18722-upstream-release-6.0-1634565455
Switched to a new branch 'automated-cherry-pick-of-mattermost-server-#18722-upstream-release-6.0-1634565455'
Branch 'automated-cherry-pick-of-mattermost-server-#18722-upstream-release-6.0-1634565455' set up to track remote branch 'release-6.0' from 'upstream'.

+++ About to attempt cherry pick of PR #18722 with merge commit bb3ac887e038b7d505c848db2febd8b08f3dbc51.


*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: unable to auto-detect email address (got 'mattermod@mattermod-bf85fdfb8-fd6s2.(none)')
!!! git cherry-pick failed

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.

[isacikgoz]

/cherry-pick release-6.0

[mattermod]

Cherry pick is scheduled.

[mattermod]

Error trying doing the automated Cherry picking. Please do this manually

+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '140.82.112.4' to the list of known hosts (/app/.ssh/known_hosts).
Fetching origin
Failed to add the RSA host key for IP address '140.82.112.4' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-server-#18722-upstream-release-6.0-1634565481
Switched to a new branch 'automated-cherry-pick-of-mattermost-server-#18722-upstream-release-6.0-1634565481'
Branch 'automated-cherry-pick-of-mattermost-server-#18722-upstream-release-6.0-1634565481' set up to track remote branch 'release-6.0' from 'upstream'.

+++ About to attempt cherry pick of PR #18722 with merge commit bb3ac887e038b7d505c848db2febd8b08f3dbc51.


*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: unable to auto-detect email address (got 'mattermod@mattermod-bf85fdfb8-fd6s2.(none)')
!!! git cherry-pick failed

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.

[amyblais]

@isacikgoz Since this is not in the master branch, what happens when we next time merge the master branch into the cloud branch? Will this fix be included in future releases, e.g. 6.2, or is this fix not needed for future releases?

[isacikgoz]

@amyblais This is similar to what happens in cloud sync PRs. At the cloud branch, we have checks for whether the migrations are missing for every DB version. If they are missing we apply the required DB migrations. Those checks are not present in the master branch. That's why we are doing these FF's manually. This fix is going to live in cloud branch so yes this will be included in the future releases.