[MM-44056] Make Calls plugin's state on Cloud controllable by feature flag #20161

streamer45 · 2022-05-09T19:45:13Z

Summary

Fortunately it looks like Apps solved our problem already so I am following a similar approach.

Calls will be pre-packaged and set to enabled by default which means it gets installed automatically on first server start.
Upon actual plugin's activation we check whether the CallsEnabled feature flag is set to true and only in that case we allow the plugin to be started.

None of this should impact on-prem as all the checks are guarded by the IsCloud util (leveraging MM_CLOUD_INSTALLATION_ID).

Since we are here, I also added the code to pre-package as it will make it easier to test this PR. Just bear in mind I may have to bump the plugin's version before merging to get the latest changes necessary for it to work properly on Cloud.

Ticket Link

https://mattermost.atlassian.net/browse/MM-44056

Release Note

Prepackage Calls v0.5.1

lieut-data

Nice! Just one suggestion below.

app/plugin.go

app/plugin_install.go

lieut-data · 2022-05-09T19:51:36Z

model/feature_flags.go

@@ -32,12 +32,16 @@ type FeatureFlags struct {
 	PluginPlaybooks  string `plugin_id:"playbooks"`
 	PluginApps       string `plugin_id:"com.mattermost.apps"`
 	PluginFocalboard string `plugin_id:"focalboard"`
+	PluginCalls      string `plugin_id:"com.mattermost.calls"`


I /think/ most of these are now unused, but no objection to extending.

Thanks, wasn't sure either but given there was a check that made use of those in installFeatureFlagPlugins I opted to include it although it shouldn't have any impact on the PR's scope.

cpoile

Thanks Claudio, looks great!

Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>

streamer45 · 2022-05-10T06:23:29Z

/e2e-test

mattermod · 2022-05-10T06:23:31Z

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/192493

streamer45 · 2022-05-10T06:33:23Z

@saturninoabril Could you suggest someone to have a quick look at this from a QA perspective? If possible, we are looking to merge this asap to get into tomorrow's Cloud release.

Main things to check would be:

Calls is installed but not enabled by default. No UI related to Calls should be visible to the user at this point.
Switching the CallsEnabled feature flag to true enables the plugin.
Switching the CallsEnabled feature flag to false disables the plugin.
Apps is enabled by default.
Switching the AppsEnabled feature flag to false disables the plugin.

/cc @amyblais

streamer45 · 2022-05-10T06:35:53Z

@angeloskyratzakos This landing on Community will likely mean we need to have the flag on in order for Calls to remain enabled. So it's about setting MM_FEATUREFLAGS_CALLSENABLED=true . Let me know if you have questions/concerns.

saturninoabril · 2022-05-10T10:11:24Z

Claudio, I'll take a look.

streamer45 · 2022-05-10T10:12:02Z

Claudio, I'll take a look.

Amazing, thank you 🙌

saturninoabril

Thanks @streamer45! Tested and passed.

streamer45 · 2022-05-10T17:08:45Z

/update-branch

mm-cloud-bot · 2022-05-10T17:29:54Z

Test server destroyed

mm-cloud-bot · 2022-05-10T17:29:56Z

Test server destroyed

streamer45 · 2022-05-10T17:30:42Z

/cherry-pick cloud

mattermod · 2022-05-10T17:30:43Z

Cherry pick is scheduled.

… flag (mattermost#20161) * Make Calls plugin's state on Cloud controllable by feature flag * Prepackage Calls v0.4.9 (mattermost#20148) * Update app/plugin.go Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> * Update app/plugin_install.go Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> * Bump Calls version to latest Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com> (cherry picked from commit aee68c7)

…attermost#20161-upstream-cloud

… flag (#20161) (#20174) * Make Calls plugin's state on Cloud controllable by feature flag * Prepackage Calls v0.4.9 (#20148) * Update app/plugin.go Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> * Update app/plugin_install.go Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> * Bump Calls version to latest Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com> (cherry picked from commit aee68c7) Co-authored-by: Claudio Costa <cstcld91@gmail.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

… flag (#20161) * Make Calls plugin's state on Cloud controllable by feature flag * Prepackage Calls v0.4.9 (#20148) * Update app/plugin.go Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> * Update app/plugin_install.go Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> * Bump Calls version to latest Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

… flag (mattermost#20161) * Make Calls plugin's state on Cloud controllable by feature flag * Prepackage Calls v0.4.9 (mattermost#20148) * Update app/plugin.go Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> * Update app/plugin_install.go Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> * Bump Calls version to latest Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

streamer45 added 2 commits May 9, 2022 21:44

Make Calls plugin's state on Cloud controllable by feature flag

00f7f30

Prepackage Calls v0.4.9 (#20148)

dd07ba0

streamer45 added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 9, 2022

streamer45 requested review from lieut-data, cpoile and gabrieljackson May 9, 2022 19:45

streamer45 self-assigned this May 9, 2022

mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 9, 2022

lieut-data approved these changes May 9, 2022

View reviewed changes

cpoile approved these changes May 9, 2022

View reviewed changes

streamer45 and others added 2 commits May 9, 2022 22:04

Update app/plugin.go

740df6a

Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>

Update app/plugin_install.go

086f6a1

Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>

streamer45 added the Setup Cloud Test Server Setup an on-prem test server label May 10, 2022

streamer45 added the 2: Infra Review Requires review by a SRE label May 10, 2022

streamer45 requested a review from angeloskyratzakos May 10, 2022 06:35

streamer45 mentioned this pull request May 10, 2022

[MM-44056] Make plugin start in Cloud opt-in mattermost/mattermost-plugin-calls#66

Closed

saturninoabril self-requested a review May 10, 2022 10:11

amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label May 10, 2022

saturninoabril approved these changes May 10, 2022

View reviewed changes

saturninoabril added QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process) and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 10, 2022

angeloskyratzakos approved these changes May 10, 2022

View reviewed changes

streamer45 removed the 2: Infra Review Requires review by a SRE label May 10, 2022

streamer45 added 4: Reviews Complete All reviewers have approved the pull request Do Not Merge Should not be merged until this label is removed labels May 10, 2022

Bump Calls version to latest

110aed7

streamer45 removed the Do Not Merge Should not be merged until this label is removed label May 10, 2022

Merge branch 'master' into MM-44056

2395d01

streamer45 merged commit aee68c7 into master May 10, 2022

streamer45 deleted the MM-44056 branch May 10, 2022 17:29

mattermod removed the Setup Cloud Test Server Setup an on-prem test server label May 10, 2022

mattermost-build mentioned this pull request May 10, 2022

Automated cherry pick of #20161 #20174

Merged

mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels May 10, 2022

amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels May 10, 2022

mattermod added a commit to mattermost-build/mattermost that referenced this pull request May 10, 2022

Merge branch 'cloud' into automated-cherry-pick-of-mattermost-server-m…

d048667

…attermost#20161-upstream-cloud

mattermod added a commit to mattermost-build/mattermost that referenced this pull request May 10, 2022

Merge branch 'cloud' into automated-cherry-pick-of-mattermost-server-m…

fe9a5ad

…attermost#20161-upstream-cloud

amyblais added Docs/Needed Requires documentation and removed Docs/Not Needed Does not require documentation labels May 27, 2022

amyblais added this to the v7.0 milestone May 27, 2022

amyblais unassigned streamer45 Jun 1, 2022

justinegeffen added Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Jun 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MM-44056] Make Calls plugin's state on Cloud controllable by feature flag #20161

[MM-44056] Make Calls plugin's state on Cloud controllable by feature flag #20161

streamer45 commented May 9, 2022 •

edited

lieut-data left a comment

lieut-data May 9, 2022

streamer45 May 9, 2022

cpoile left a comment

streamer45 commented May 10, 2022

mattermod commented May 10, 2022

streamer45 commented May 10, 2022

streamer45 commented May 10, 2022

saturninoabril commented May 10, 2022

streamer45 commented May 10, 2022

saturninoabril left a comment

streamer45 commented May 10, 2022

mm-cloud-bot commented May 10, 2022

mm-cloud-bot commented May 10, 2022

streamer45 commented May 10, 2022

mattermod commented May 10, 2022

[MM-44056] Make Calls plugin's state on Cloud controllable by feature flag #20161

[MM-44056] Make Calls plugin's state on Cloud controllable by feature flag #20161

Conversation

streamer45 commented May 9, 2022 • edited

Summary

Ticket Link

Release Note

lieut-data left a comment

Choose a reason for hiding this comment

lieut-data May 9, 2022

Choose a reason for hiding this comment

streamer45 May 9, 2022

Choose a reason for hiding this comment

cpoile left a comment

Choose a reason for hiding this comment

streamer45 commented May 10, 2022

mattermod commented May 10, 2022

streamer45 commented May 10, 2022

streamer45 commented May 10, 2022

saturninoabril commented May 10, 2022

streamer45 commented May 10, 2022

saturninoabril left a comment

Choose a reason for hiding this comment

streamer45 commented May 10, 2022

mm-cloud-bot commented May 10, 2022

mm-cloud-bot commented May 10, 2022

streamer45 commented May 10, 2022

mattermod commented May 10, 2022

streamer45 commented May 9, 2022 •

edited