Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-45993: Return errors during sending websocket messages #20760

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Commits on Aug 3, 2022

  1. MM-45993: Return errors during sending websocket messages

    During attaching an object to a websocket message, we would
    marshal it to json and attach the string output. But if the
    marshalling failed, we would just log a warning and move on.
    
    This would add an empty string to the message. But the client
    assumes that the object is correctly attached and would
    fail silently if it cannot find it.
    
    So we become more strict and return the error so that
    it reaches the caller.
    
    https://mattermost.atlassian.net/browse/MM-45993
    
    ```release-note
    NONE
    ```
    agnivade committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    09b0f55 View commit details
    Browse the repository at this point in the history