[15921] Disable email notifications for the bot user #20938
Conversation
|
@ashikjm: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. I understand the commands that are listed here |
mm-cloud-bot
added
release-note
|
Hey @ashikjm thanks for the contribution! Let us know if you need any help regarding to failing tests. |
|
@isacikgoz yes please. All the tests are failing with the same error. |
|
@isacikgoz Looks like re-requesting review from @mkraft (as there were some changes suggested) have removed you from the reviewers list. I dont have the permissions to add you back to the reviewers list. :( Regarding the tests, I see they are failing stating that there are no test files for wsapi. Could you guide me here? |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
| t.Run("fetch user 1", func(t *testing.T) { | ||
| actual, err := ss.User().GetNotifyProps(u1.Id) | ||
| require.NoError(t, err) | ||
| require.Equal(t, u1, actual) |
There was a problem hiding this comment.
You are trying to compare a *model.User to a map[string]string instance here. Hence it's failing.
There was a problem hiding this comment.
gentle ping about this comment.
|
Hi @ashikjm, big thanks for your contribution! There hasn't been recent activity on this PR so I've marked it as inactive. Following our inactive contribution process, the PR is now closed due to 30 days or more of inactivity. However, if you're still interested working on the changes, let us know! Note that we merged multiple repositories into one monorepo, which may require you to resubmit the changes. If you have any questions, don't hesitate to let us know, we're happy to help. |
Summary
This commit disables the email notifications for the bot accounts. Currently, they are set to
truewhich caused bounce back messages when someone DM's the bot.Additionally, when a user is converted to bot, the email notifications are disabled and when a bot is converted to user, email notifications are enabled.
Ticket Link
Fixes #15921
Release Notes