New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-47137] P2 // Fix active_user_count
increasing without the users themselves logging in
#21437
base: master
Are you sure you want to change the base?
Conversation
active_user_count
increasing without the users themselves logging inactive_user_count
increasing without the users themselves logging in
active_user_count
increasing without the users themselves logging inactive_user_count
increasing without the users themselves logging in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
… MM-47137_user_deleted_activity_fix
Successfully triggered E2E testing! |
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
/update-branch |
/e2e-test |
Successfully triggered E2E testing! |
/e2e-test |
Successfully triggered E2E testing! |
Summary
active_user_count
metric was being counted wrongly, when a user with no activity was deleted. This PR introduces a flag calledupdateLastActivityAt
which conditionally updatesstatus.lastActivityAt
.Ticket Link
https://mattermost.atlassian.net/browse/MM-47137
Release Note