-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-51774] - Fire a telemetry event when System Console is clicked in-product #22980
base: master
Are you sure you want to change the base?
Conversation
@AGMETEOR: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. I understand the commands that are listed here |
/update-branch |
@@ -78,6 +80,7 @@ const ConfigureLink = (props: {pluginId: string; pluginName: string}) => { | |||
<Link | |||
to={'/admin_console/plugins/plugin_' + props.pluginId} | |||
style={{color: 'var(--denim-button-bg)', fontWeight: '600'}} | |||
onClick={() => trackEvent('system_admin', 'system_console_visit', {location: 'custom_open_plugin_intall_post_renderer'})} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be custom_open_plugin_install_post_renderer
? (changed intall to install)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Going to change it
Hey @nickmisasi gentle ping here |
@@ -264,6 +264,7 @@ class ProcessPaymentSetup extends React.PureComponent<Props, State> { | |||
tertiaryButtonHandler={() => { | |||
this.props.onClose(); | |||
this.props.history.push('/admin_console/billing/subscription'); | |||
trackEvent('system_admin', 'system_console_visit', {location: 'switch_to_annual > purchase_modal > success'}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add system_admin
to TELEMETRY_CATEGORIES constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question regarding a similar event.
}; | ||
|
||
export const TELEMETRY_EVENT = { | ||
SYSTEM_CONSOLE_VISIT: 'system_console_visit', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming convention followed is *Action/Event Taken* + _ + *Object Taken Action On (optional - if any)* + _ + *Purpose/Result Of The Action*
. Based on that click_system_console
looks like a more matching name. However, such event already exists. Any chance that the new event duplicates the existing one?
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Summary
This PR adds ability to track when the system console is visited. This can be from the product switcher menu, some links outside the console itself but in-product and different email templates
Ticket Link
https://mattermost.atlassian.net/browse/MM-51774
Release Note