MM-42752 : Channel header icons impacted by long channel name in mobile view #23138
Conversation
|
@Manishpandey11: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. I understand the commands that are listed here |
|
Hello @Manishpandey11, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
M-ZubairAhmed
changed the title
|
/release-note-none |
mm-cloud-bot
added
release-note-none
| @@ -218,4 +218,4 @@ | |||
| .badge-notify { | |||
| background: $red; | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
add empty line after the last line
| @@ -104,16 +102,14 @@ class MobileChannelHeaderPlug extends React.PureComponent<Props> { | |||
| } | |||
|
|
|||
| return ( | |||
| <li className='flex-parent--center'> | |||
There was a problem hiding this comment.
you may as well remove flex-parent--center from stylesheet since it is only used in this component
M-ZubairAhmed
added
2: Dev Review
|
E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label. |
|
Creating a new SpinWick test server using Mattermost Cloud. |
|
Enterprise Edition Image not available in the 30 minutes timeframe, checking the Team Edition Image and if available will use that. |
|
It seems there may be an issue with the test server. Can't test this at the moment |
M-ZubairAhmed
added
EETests
and removed
Setup Cloud Test Server
There was a problem hiding this comment.
Thanks @Manishpandey11 can you just resolve the linting error 🎉
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Summary
Modified the code so that channel name truncates if necessary and channel header icons unaffected
Ticket Link
Fixes #19858
Release Note