Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-23058] UI Enhancement: use icons in Settings > Import submenu #23461

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tejaskarelia17
Copy link
Contributor

Summary

This PR enhances the UI for the import submenu in the main settings for boards. Add a separation in the submenu between import action and external links for docs to import from other 3rd party applications. Title the below section of the submenu as External import docs to signify external links to documentation.

  • Change "Import archive" → "Import archive file"
  • Add a separate between import action and external links
  • Add "External import docs" as title for external links

Ticket Link

Fixes GitHub issue mattermost/focalboard#4840

Screenshots

before after

Release Note

NONE

@mm-cloud-bot
Copy link

@tejaskarelia17: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @tejaskarelia17,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@M-ZubairAhmed M-ZubairAhmed added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 20, 2023
@mattermost-build
Copy link
Contributor

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

@crspeller crspeller removed their request for review May 23, 2023 22:17
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@calebroseland calebroseland requested review from sbishel and removed request for calebroseland June 6, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Contributor do-not-merge/release-note-label-needed Lifecycle/1:stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants