Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLD-5698 - Add e2e smoketests #23590

Merged
merged 11 commits into from Jun 12, 2023
Merged

CLD-5698 - Add e2e smoketests #23590

merged 11 commits into from Jun 12, 2023

Conversation

mvitale1989
Copy link
Member

@mvitale1989 mvitale1989 commented Jun 2, 2023

Summary

This PR reintroduces the Github Actions E2E smoketests originally added by #23301 , but fixes the first PR's problem which prevented the full E2E tests from running.

The root cause was the change to the docker-compose file networking, which was not expected by the currently existing E2E test run scripts. That has been addressed in this PR.

tl;dr of the changes compared to #23301 :

  • Fix the root cause of the revert: do not change the docker-compose networking that E2E scripts currently rely on.
  • Use Docker Hub as a registry, for the images required by E2E tests
  • Push the images required by E2E to Docker Hub, in CI
  • Fix a bug in the e2e-tests-ci workflow: use the inputs.commit_sha wherever required
  • Fix other minor issues

Ticket Link

https://mattermost.atlassian.net/browse/CLD-5698
https://mattermost.atlassian.net/browse/CLD-5703

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 2, 2023
@mvitale1989 mvitale1989 force-pushed the cdl-5698-e2e-smoketests branch 2 times, most recently from 782bd1b to 4aa0b94 Compare June 2, 2023 10:56
@mvitale1989
Copy link
Member Author

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@mvitale1989 mvitale1989 marked this pull request as ready for review June 5, 2023 17:58
@mvitale1989
Copy link
Member Author

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

Copy link
Contributor

@toninis toninis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI file is good from my side . Ping me to test once merged with a new PR 🚀

@saturninoabril saturninoabril changed the title CDL-5698 - Add e2e smoketests CLD-5698 - Add e2e smoketests Jun 6, 2023
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mario, great work!

e2e-tests/README.md Outdated Show resolved Hide resolved
e2e-tests/README.md Outdated Show resolved Hide resolved
e2e-tests/.ci/server.prepare.sh Outdated Show resolved Hide resolved
@agnivade agnivade requested review from isacikgoz and removed request for agnivade June 7, 2023 03:13
mvitale1989 and others added 8 commits June 9, 2023 09:58
- Port E2E testing scripts from cypress-ui-automation
- Move server to docker-compose, move E2E images to ecrpublic
* Integrate General channel renaming, fixes
- Add local automation-dashboard
- Add readme
- Add E2E smoketests
- Bump postgres to 12

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com>
Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com>
Fix typos

Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com>
@mvitale1989
Copy link
Member Author

/e2e-test MM_ENV="MM_SERVICEENVIRONMENT=test"

@mattermost-build
Copy link
Contributor

Triggering E2E testing with options:
&map[MM_ENV:MM_SERVICEENVIRONMENT=test]

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@mvitale1989
Copy link
Member Author

/e2e-test MM_ENV="MM_SERVICEENVIRONMENT=test"

@mattermost-build
Copy link
Contributor

Triggering E2E testing with options:
&map[MM_ENV:MM_SERVICEENVIRONMENT=test]

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@mvitale1989 mvitale1989 merged commit 0445d83 into master Jun 12, 2023
24 checks passed
@mvitale1989 mvitale1989 deleted the cdl-5698-e2e-smoketests branch June 12, 2023 09:56
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jun 12, 2023
karan2704 pushed a commit to karan2704/mattermost-server that referenced this pull request Jun 21, 2023
* Prepare: run E2E smoketests with GitHub actions (mattermost#23301)
* Port E2E testing scripts from cypress-ui-automation
* Move server to docker-compose, move E2E images to ecrpublic
* Integrate General channel renaming, fixes
* Add local automation-dashboard
 Add readme
* Add E2E smoketests
* Bump postgres to 12
* Fully rely on mattermostdevelopment images

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com>
Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com>
sbishel pushed a commit to sbishel/mattermost that referenced this pull request Aug 15, 2023
* Prepare: run E2E smoketests with GitHub actions (mattermost#23301)
* Port E2E testing scripts from cypress-ui-automation
* Move server to docker-compose, move E2E images to ecrpublic
* Integrate General channel renaming, fixes
* Add local automation-dashboard
 Add readme
* Add E2E smoketests
* Bump postgres to 12
* Fully rely on mattermostdevelopment images

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com>
Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants