Mobile Web view : I am not able to create a new category #23619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
the
release-note
|
Hello @hchorfispiria, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
M-ZubairAhmed
added
2: Dev Review
|
E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label. |
M-ZubairAhmed
requested review from
M-ZubairAhmed
and removed request for
marianunez
M-ZubairAhmed
requested changes
Jun 9, 2023
| @@ -98,6 +99,7 @@ export function Menu(props: Props) { | |||
| function handleMenuModalClose(modalId: MenuProps['id']) { | |||
| dispatch(closeModal(modalId)); | |||
| setAnchorElement(null); | |||
| props.onMenuModalClose(); | |||
There was a problem hiding this comment.
i am curious why did we had to pass this another close function when we already have dispatch(closeModal(modalId)); on the line above
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On Mattermost web mobile, I'm not able to create a new category.
Ticket Link
Link
Screenshots
Release Note