Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-53482 : Removed code related to "Enable Preview Features" setting #24028

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

EvaGraceSmith
Copy link

@EvaGraceSmith EvaGraceSmith commented Jul 13, 2023

Summary

  1. Removed all remaining references to ServiceSettings.EnablePreviewFeatures on the server and web app
  2. Removed the deleteUnusedFeatures cleanup function from the SqlPreferenceStore on the server as well as the
    FeatureTogglePrefix constant used by that code
  3. Removed the code from the UserSettingsAdvanced component that used to offer a list of preview features to the user if EnablePreviewFeatures was enabled
  4. Removed the code that uses the FeatureTogglePrefix and PRE*RELEASE*FEATURES constants on the web app

Ticket Link

Fixes #23985
Jira https://mattermost.atlassian.net/browse/MM-53482

Screenshots

Release Note

NONE


KatiLee and others added 7 commits July 13, 2023 18:20
Co-authored-by: Katherine Lee <katherineleefoley@gmail.com>
Co-authored-by: Eva Grace Smith <smithevagrace@gmail.com>
Co-authored-by: Katherine Lee <katherineleefoley@gmail.com>
Co-authored-by: Eva Grace Smith <smithevagrace@gmail.com>
Co-authored-by: Katherine Lee <katherineleefoley@gmail.com>
Co-authored-by: Eva Grace Smith <smithevagrace@gmail.com>
Co-authored-by: Katherine Lee <katherineleefoley@gmail.com>
Co-authored-by: Eva Grace Smith <smithevagrace@gmail.com>
Co-authored-by: Katherine Lee <katherineleefoley@gmail.com>
Co-authored-by: Eva Grace Smith <smithevagrace@gmail.com>
Co-authored-by: Katherine Lee <katherineleefoley@gmail.com>
Co-authored-by: Eva Grace Smith <smithevagrace@gmail.com>
Co-authored-by: Katherine Lee <katherineleefoley@gmail.com>
Co-authored-by: Eva Grace Smith <smithevagrace@gmail.com>
@mm-cloud-bot
Copy link

@EvaGraceSmith: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @EvaGraceSmith,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@M-ZubairAhmed M-ZubairAhmed changed the title Removed code related to "Enable Preview Features" setting #23985 MM-53482 : Removed code related to "Enable Preview Features" setting Jul 14, 2023
@M-ZubairAhmed
Copy link
Member

/release-note-none

@mm-cloud-bot mm-cloud-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed labels Jul 14, 2023
@M-ZubairAhmed M-ZubairAhmed added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Jul 14, 2023
@mattermost-build
Copy link
Contributor

E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts.

@harshilsharma63
Copy link
Member

Hi @EvaGraceSmith 👋 Thanks a ton for the PR! Can you please check out the failing CI steps? Mostly due to lint errors I believe.

@harshilsharma63
Copy link
Member

Changes look fine overall, but due to unused imports in server-side, the server doesn't even compile. Can you make sure to fix the lint issues and try out the changes?

Copy link
Member

@harshilsharma63 harshilsharma63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting lint and CI fix. Changes look good otherwise

Copy link
Member

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EvaGraceSmith! LGTM - pending fixing linting errors.

@EvaGraceSmith
Copy link
Author

EvaGraceSmith commented Aug 6, 2023 via email

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Copy link
Member

@harshilsharma63 harshilsharma63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting server compilation error.

@marianunez
Copy link
Member

@EvaGraceSmith just checking in - let us know if there is any help you would need to fix the CI errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Contributor Lifecycle/1:stale release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove code related to "Enable Preview Features" setting
7 participants