-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-53482 : Removed code related to "Enable Preview Features" setting #24028
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Katherine Lee <katherineleefoley@gmail.com> Co-authored-by: Eva Grace Smith <smithevagrace@gmail.com>
Co-authored-by: Katherine Lee <katherineleefoley@gmail.com> Co-authored-by: Eva Grace Smith <smithevagrace@gmail.com>
Co-authored-by: Katherine Lee <katherineleefoley@gmail.com> Co-authored-by: Eva Grace Smith <smithevagrace@gmail.com>
Co-authored-by: Katherine Lee <katherineleefoley@gmail.com> Co-authored-by: Eva Grace Smith <smithevagrace@gmail.com>
Co-authored-by: Katherine Lee <katherineleefoley@gmail.com> Co-authored-by: Eva Grace Smith <smithevagrace@gmail.com>
Co-authored-by: Katherine Lee <katherineleefoley@gmail.com> Co-authored-by: Eva Grace Smith <smithevagrace@gmail.com>
Co-authored-by: Katherine Lee <katherineleefoley@gmail.com> Co-authored-by: Eva Grace Smith <smithevagrace@gmail.com>
@EvaGraceSmith: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. I understand the commands that are listed here |
Hello @EvaGraceSmith, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
/release-note-none |
E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts. |
Hi @EvaGraceSmith 👋 Thanks a ton for the PR! Can you please check out the failing CI steps? Mostly due to lint errors I believe. |
Changes look fine overall, but due to unused imports in server-side, the server doesn't even compile. Can you make sure to fix the lint issues and try out the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awaiting lint and CI fix. Changes look good otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @EvaGraceSmith! LGTM - pending fixing linting errors.
Thank you! I will work on getting the linting errors fixed this weekend!
…On Thu, Jul 27, 2023 at 5:21 PM Maria A Nunez ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks @EvaGraceSmith <https://github.com/EvaGraceSmith>! LGTM - pending
fixing linting errors.
—
Reply to this email directly, view it on GitHub
<#24028 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3OUH6LXOJCR6ZMUKLY5CDDXSLSWNANCNFSM6AAAAAA2JRHYCI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awaiting server compilation error.
@EvaGraceSmith just checking in - let us know if there is any help you would need to fix the CI errors |
Summary
ServiceSettings.EnablePreviewFeatures
on the server and web appdeleteUnusedFeatures
cleanup function from theSqlPreferenceStore
on the server as well as theFeatureTogglePrefix
constant used by that codeUserSettingsAdvanced
component that used to offer a list of preview features to the user ifEnablePreviewFeatures
was enabledFeatureTogglePrefix
andPRE*RELEASE*FEATURES
constants on the web appTicket Link
Fixes #23985
Jira https://mattermost.atlassian.net/browse/MM-53482
Screenshots
Release Note
NONE