Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-54803] Convert ./components/channel_header_dropdown/mobile_channel_header_dropdown_animation.tsx from Class to Functional component #24949

Merged
merged 3 commits into from Oct 30, 2023
Merged

[MM-54803] Convert ./components/channel_header_dropdown/mobile_channel_header_dropdown_animation.tsx from Class to Functional component #24949

merged 3 commits into from Oct 30, 2023

Conversation

Kritik-J
Copy link
Contributor

Summary

This PR Convert ./components/channel_header_dropdown/mobile_channel_header_dropdown_animation.tsx from Class to Functional component

Ticket Link

fixes: #24766

Jira Ticket

https://mattermost.atlassian.net/browse/MM-54803

Release Note

Convert ./components/channel_header_dropdown/mobile_channel_header_dropdown_animation.tsx from Class to Functional component

@Kritik-J
Convert ./components/channel_header_dropdown/mobile_channel_header_dr…
78c738a 
…opdown_animation.tsx from Class to Functional component
@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 16, 2023
@mattermost-build
Copy link
Contributor

Hello @Kritik-J,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@M-ZubairAhmed M-ZubairAhmed added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Oct 16, 2023
@mattermost-build
Copy link
Contributor

E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts.

@larkox larkox self-requested a review October 16, 2023 13:42
larkox
larkox requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a minor change.

...channels/src/components/channel_header_dropdown/mobile_channel_header_dropdown_animation.tsx Outdated Show resolved Hide resolved
jespino
jespino approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me. Thanks @Kritik-J! 🎉

@jespino jespino removed the 2: Dev Review Requires review by a developer label Oct 18, 2023
@jespino jespino requested a review from lindy65 October 18, 2023 08:08
@lindy65
Copy link
Contributor

lindy65 commented Oct 18, 2023

/update-branch

@lindy65 lindy65 added the QA-wanted Available for QA review by QA contributors during Hacktoberfest label Oct 18, 2023
@josephjosedev
Copy link

@lindy65 i would like to test this PR as a QA

@lindy65 lindy65 added the Setup Cloud Test Server Setup an on-prem test server label Oct 23, 2023
@lindy65
Copy link
Contributor

lindy65 commented Oct 23, 2023 •
edited

Thanks @josephjosedev - the test server is ready. You will need to test this on the latest build of the mobile app as the channel drop-down menu in mobile needs to be smoke-tested. Log into the test server from mobile using either of the login credentials.

Let me know if you have any questions :)

@lindy65 lindy65 removed the QA-wanted Available for QA review by QA contributors during Hacktoberfest label Oct 23, 2023
@josephjosedev
Copy link

@lindy65
image
Need to test this one right?

@lindy65
Copy link
Contributor

lindy65 commented Oct 23, 2023

Hi @josephjosedev - yes - tap on the name "Off Topic" and test some of the options that you see in the menu that appears after tapping on the channel name.

Also, create your own new public and private channels and test the channel drop-down from these newly created channels

@larkox
Copy link
Contributor

larkox commented Oct 23, 2023

@lindy65 @josephjosedev The idea here is not so much about the mobile application, but mobile web browser. You can test this either by opening the mattermost server from a browser in the phone (instead of from the app), or reduce the width of the browser to a really narrow size. Sorry for the confusion!

@lindy65
Copy link
Contributor

lindy65 commented Oct 23, 2023

@lindy65 @josephjosedev The idea here is not so much about the mobile application, but mobile web browser. You can test this either by opening the mattermost server from a browser in the phone (instead of from the app), or reduce the width of the browser to a really narrow size. Sorry for the confusion!

Aah! Thanks for the clarification @larkox :)

@josephjosedev
Copy link

josephjosedev commented Oct 23, 2023 •
edited

@lindy65 I Tested the options on the channel dropdown and some bugs are noted and the noted issues are attaching below
image
1.On channel Action Option the placeholder text is cutoffed..
2.
image
Convert to private channel option 2 buttons are touching Yes and No button

image
Add members invite to the team text is congested in the space..

lindy65
lindy65 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kritik-J - looks good 👍

@josephjosedev - thanks for your thorough QA! I'll file separate tickets for the issues you found as they are not caused by this PR

cc @larkox

@lindy65 lindy65 added 4: Reviews Complete All reviewers have approved the pull request QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process) and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Setup Cloud Test Server Setup an on-prem test server labels Oct 24, 2023
@mm-cloud-bot
Copy link

Test server destroyed

@larkox
Copy link
Contributor

larkox commented Oct 24, 2023

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@larkox larkox merged commit 7ea88ff into mattermost:master Oct 30, 2023
15 checks passed
@larkox
Copy link
Contributor

larkox commented Oct 30, 2023

Thank you for the contribution!

@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 30, 2023
@jwilander jwilander added the kind/refactor Categorizes issue or PR as related to refactor of production code. label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jespino jespino jespino approved these changes

@larkox larkox larkox approved these changes

@lindy65 lindy65 lindy65 approved these changes

Assignees

@josephjosedev josephjosedev

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Contributor Docs/Not Needed Does not require documentation Hacktoberfest hacktoberfest-accepted kind/refactor Categorizes issue or PR as related to refactor of production code. QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process) release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
10 participants
@Kritik-J @mattermost-build @lindy65 @josephjosedev @larkox @mm-cloud-bot @jespino @jwilander @M-ZubairAhmed @amyblais