Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock wrangler behind enterprise #25703

Merged
merged 6 commits into from Jan 5, 2024
Merged

Lock wrangler behind enterprise #25703

merged 6 commits into from Jan 5, 2024

Conversation

nickmisasi
Copy link
Contributor

@nickmisasi nickmisasi commented Dec 12, 2023

Summary

At John's request, locking wrangler behind a license. This change will make it so that any license (Professional, Enterprise, E10/E20, etc) will allow the wrangler feature to be used.

Ticket Link

Screenshots

Release Note

Move Threads (Experimental) requires a Professional/Enterprise license to activate

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 12, 2023
@nickmisasi
Copy link
Contributor Author

/update-branch

@nickmisasi nickmisasi added the 2: Dev Review Requires review by a developer label Jan 3, 2024
@nickmisasi nickmisasi added the 1: PM Review Requires review by a product manager label Jan 3, 2024
@mm-cloud-bot mm-cloud-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 3, 2024
Copy link

@johndavidlugtu johndavidlugtu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nick

Copy link
Contributor

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmhealey
Copy link
Member

hmhealey commented Jan 5, 2024

To echo some discussion we've had here in case anyone comes across this PR and is concerned about this being EE-only, we're currently planning to make most of this available without a license once it's no longer experiemental. It's just easier for us to work on it and break things while there are fewer people depending on the current functionality which might change

@nickmisasi nickmisasi added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer 1: PM Review Requires review by a product manager labels Jan 5, 2024
@nickmisasi nickmisasi merged commit e52940c into master Jan 5, 2024
52 checks passed
@nickmisasi nickmisasi deleted the lock-wrangler-enterprise branch January 5, 2024 18:20
@amyblais amyblais added Docs/Needed Requires documentation Changelog/Done Required changelog entry has been written labels Jan 5, 2024
@amyblais amyblais added this to the v9.5.0 milestone Jan 5, 2024
@cwarnermm cwarnermm removed the Docs/Needed Requires documentation label Feb 12, 2024
@cwarnermm cwarnermm added the Docs/Not Needed Does not require documentation label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants