[MM-57743] Enable errcheck linter #26723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
the
release-note-none
|
|
|
hanzei
force-pushed
the
MM-57743_errcheck
branch
2 times, most recently
from
f001f8f
to
81e8497
Compare
hanzei
force-pushed
the
MM-57743_errcheck
branch
from
81e8497
to
f50d151
Compare
hanzei
commented
Apr 24, 2024
| skip-dirs: | ||
| exclude-dirs: |
There was a problem hiding this comment.
skip-dirs doesn't exist. Fixing that as part of this PR.
| @@ -26,11 +26,10 @@ linters: | |||
| - goimports | |||
| - makezero | |||
| - whitespace | |||
| # TODO: enable this later | |||
There was a problem hiding this comment.
4 years later, we can finally remove this
Comment on lines
-110
to
+111
| // FixInvalidLocales checks and corrects the given config for invalid locale-related settings. | ||
| // | ||
| // Ideally, this function would be completely internal, but it's currently exposed to allow the cli | ||
| // to test the config change before allowing the save. | ||
| func FixInvalidLocales(cfg *model.Config) bool { | ||
| // fixInvalidLocales checks and corrects the given config for invalid locale-related settings. | ||
| func fixInvalidLocales(cfg *model.Config) bool { |
There was a problem hiding this comment.
Fixing the comment while touching the package
Comment on lines
+83
to
+85
| // utils.TranslationsPreInit errors when TestFixInvalidLocales is run as part of testing the package, | ||
| // but doesn't error when the test is run individually. | ||
| _ = utils.TranslationsPreInit() |
There was a problem hiding this comment.
I haven't found out why, though.
There was a problem hiding this comment.
Do we know the error? Maybe we can create a ticket to track or create a HW issue.
hanzei
added
2: Dev Review
agnivade
approved these changes
Apr 26, 2024
isacikgoz
approved these changes
Apr 26, 2024
Comment on lines
+83
to
+85
| // utils.TranslationsPreInit errors when TestFixInvalidLocales is run as part of testing the package, | ||
| // but doesn't error when the test is run individually. | ||
| _ = utils.TranslationsPreInit() |
There was a problem hiding this comment.
Do we know the error? Maybe we can create a ticket to track or create a HW issue.
hanzei
added
4: Reviews Complete
jwilander
added
the
kind/refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR enables the
errchecklinter, something that was planned for a few years now.The ignore list is quite broad. We can scope it down more granularly once we have a clear idea of how we do that. (Campain, staff member, don't work on it for now?)
First, I want to fix the issues in the enterprise code, as we can't do that with the community.
Ticket Link
https://mattermost.atlassian.net/browse/MM-57743
Release Note