Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(.github/holopin.yml): add holopin configuration file to manage… #26808

Merged
merged 3 commits into from
May 24, 2024

Conversation

azigler
Copy link
Contributor

@azigler azigler commented Apr 16, 2024

Fixes #26807

NONE

cc @lindy65 @iyampaul

… community contributions

The new holopin.yml file will help manage community contributions by assigning stickers to contributors. This will make it easier to recognize and appreciate the efforts of our community contributors, fostering a more engaging and rewarding open-source environment.
@mm-cloud-bot
Copy link

@azigler: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@azigler
Copy link
Contributor Author

azigler commented Apr 16, 2024

/release-note-none

@azigler
Copy link
Contributor Author

azigler commented May 5, 2024

@lindy65 Anyone we can ping to un-stuck this?

@hanzei
Copy link
Contributor

hanzei commented May 6, 2024

/update-branch

@lindy65
Copy link
Contributor

lindy65 commented May 6, 2024

Thanks for your review @hanzei 🎉

If a 2nd review is required, I was thinking that perhaps @iyampaul could review?

cc// @azigler

@lindy65 lindy65 requested a review from iyampaul May 6, 2024 08:07
@hanzei hanzei added 2: Dev Review Requires review by a developer 3: Security Review Review requested from Security Team and removed 2: Dev Review Requires review by a developer labels May 6, 2024
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: Security Review Review requested from Security Team labels May 6, 2024
@lindy65
Copy link
Contributor

lindy65 commented May 22, 2024

/update-branch

@azigler
Copy link
Contributor Author

azigler commented May 23, 2024

Not sure why these a build check failed, as this is just adding a .github files for Holopin. @saturninoabril any ideas here? Can we just re-run the check?

@saturninoabril
Copy link
Member

@azigler Did the re-run and passed. Now onto the last check (enterprise test). Feel free to merge after.

@azigler
Copy link
Contributor Author

azigler commented May 23, 2024

Wow, that's a lot of checks for what is ultimately a code-less PR. I'm wondering what I should be learning from this, in terms of reducing barriers to contribution for community members -- or at least setting them up with the right expectation of the checks they need to pass to get merged.

@saturninoabril
Copy link
Member

saturninoabril commented May 24, 2024

Thanks for the feedback and yes, totally agree. Streamlining the process would be a good next step -- what to run depending on change. We have "path" filters in few places, but definitely something to review as a whole. Specifically, this line caught the change here that triggered multiple checks as required to run.

@saturninoabril saturninoabril merged commit 50ac6fc into mattermost:master May 24, 2024
28 checks passed
@lindy65
Copy link
Contributor

lindy65 commented May 24, 2024

Thanks for your help on this! @holopin-bot @azigler Mattermost QA Community Contributors

Copy link

holopin-bot bot commented May 24, 2024

Congratulations @azigler, you just earned a badge! Here it is: https://holopin.io/claim/clwkbqox824810ckxhm0ncmn9

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .github/holopin.yml
8 participants