Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-57719] Convert ./components/form_error.tsx from Class Component to Function Component #26827

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

Summary

Convert ./components/form_error.tsx from Class Component to Function Component

Ticket Link

Fixes #26687
Jira https://mattermost.atlassian.net/browse/MM-57719

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 20, 2024
@mattermost-build
Copy link
Contributor

Hello @Syed-Ali-Abbas-Zaidi,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@larkox larkox added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Apr 22, 2024
@mattermost-build
Copy link
Contributor

E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts.

@harshilsharma63
Copy link
Member

@Syed-Ali-Abbas-Zaidi can you fix the tests? I see some snapshots failing.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@harshilsharma63
Copy link
Member

/update-branch

@larkox
Copy link
Contributor

larkox commented May 8, 2024

@Syed-Ali-Abbas-Zaidi The tests on this are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Contributor Lifecycle/1:stale release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert ./components/form_error.tsx from Class Component to Function Component
5 participants