New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-56074] mmctl job commands #26855
Open
BenCookie95
wants to merge
18
commits into
master
Choose a base branch
from
MM-56074_mmctl-job
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
the
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
label
Apr 23, 2024
BenCookie95
commented
Apr 24, 2024
BenCookie95
changed the title
WIP: [MM-56074] mmctl job commands
[MM-56074] mmctl job commands
Apr 25, 2024
hanzei
requested changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, loving the flexibility we are giving customers with these changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2: Dev Review
Requires review by a developer
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added 2 new commands to mmctl:
Added 2 new query parameters to GET
/api/v4/jobs
,job_type
andstatus
.Added a new endpoint PATCH
/api/v4/jobs/{job_id}/status
which can be used to update the status of a job. The body takes 2 fields, status and force.Status
is the new status you want to set andforce
is whether you want to bypass the status restriction that are in place. We added the force field so that admins can make an informed decision before updating a status. The status rules we have in place are:We felt that the existing permissions in place for some of the jobs weren't explicit enough so we added the following new permissions to manage the status of a job:
Ticket Link
https://mattermost.atlassian.net/browse/MM-56074
Screenshots
Release Note