Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long instance names use ellipsis when overflowed in menu item #26955

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Long instance names use ellipsis when overflowed in menu item #26955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions webapp/channels/src/components/widgets/menu/menu_items/menu_item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,15 @@
line-height: 16px;
}

div.text{
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}

span.MenuItem__primary-text {
display: inline-flex;
max-width: 100%;
padding: 5px 0;
line-height: 22px;
white-space: nowrap;
Expand Down
2 changes: 1 addition & 1 deletion webapp/channels/src/components/widgets/menu/menu_items/menu_item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default function menuItem(Component: React.ComponentType<any>) {
textProp = (
<>
<span className='icon'>{icon}</span>
{text}
<div className='text'>{text}</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only wraps the text if there is an icon. If there is no icon, it would still fail to show the ellipsis, since the style is only applied to the div.

Is that intended?

</>
);
}
Expand Down