Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaoski/MM-56819 mmctl user preference local mode support #26971

Conversation

kaoski
Copy link
Contributor

@kaoski kaoski commented May 8, 2024

Summary

This commit introduces support for --local mode in MMCTL for managing user preferences. The following changes have been added:

  1. API endpoints for user preferences are registered with the local router.
  2. Test cases have been added to ensure functionality for both System Admins and --local mode.

Note: As there is no authentication/authorization required in --local mode, @mattermod suggested omitting session checks from the API handlers. But we are already bypassing session checks for local mode requests as detailed here. Hence, I have retained the existing session checks in place.

Ticket Link

Github Issue: #26864
Jira Ticket: https://mattermost.atlassian.net/browse/MM-56819

Release Note

  1. Added --local mode support in MMCTL to handle user preferences.

@mm-cloud-bot
Copy link

@kaoski: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @kaoski,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@kaoski kaoski changed the title Kaoski/mm 56819 mmctl user preference local mode support Kaoski/MM-56819 mmctl user preference local mode support May 8, 2024
@kaoski kaoski closed this May 8, 2024
@kaoski kaoski deleted the kaoski/MM-56819-mmctl-user-preference-local-mode-support branch May 8, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants