Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Video Unavailable problem at YouTube preview #26980

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix Video Unavailable problem at YouTube preview #26980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b3826dc
Fix YouTube preview shows Video Unavailable
Sn-Kinos May 9, 2024
156264a
Fix typo on iframe property
Sn-Kinos May 9, 2024
88e5376
Remove duplicated property
Sn-Kinos May 9, 2024
18a4dbb
Merge branch 'master' into patch-1
mattermost-build Jun 9, 2024
0f24353
fix lint error (double-quotes, unknown property)
Sn-Kinos Jun 9, 2024
59ea2e1
renew snapshot for youtube_video.tsx
Sn-Kinos Jun 9, 2024
3cc4e72
fix double quotes and newline error on snapshot for youtube_video.tsx
Sn-Kinos Jun 9, 2024
ba2cb8c
fix blank on snapshot for youtube_video.tsx
Sn-Kinos Jun 9, 2024
b5fb7a4
Add YouTube Shorts Embed Preview
Sn-Kinos Jun 13, 2024
8f24ebf
Revert "Add YouTube Shorts Embed Preview"
Sn-Kinos Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions webapp/channels/src/components/youtube_video/__snapshots__/youtube_video.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,14 @@ exports[`YoutubeVideo should match snapshot for playing state 1`] = `
onClick={[Function]}
>
<iframe
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share"
allowFullScreen={true}
frameBorder="0"
height="360px"
referrerPolicy="strict-origin-when-cross-origin"
sandbox="allow-scripts allow-same-origin allow-popups allow-presentation"
src="https://www.youtube.com/embed/xqCoNej8Zxo?autoplay=1&autohide=1&border=0&wmode=opaque&fs=1&enablejsapi=1"
title="Youtube title"
width="480px"
/>
</div>
Expand Down
7 changes: 6 additions & 1 deletion webapp/channels/src/components/youtube_video/youtube_video.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export default class YoutubeVideo extends React.PureComponent<Props, State> {
const {metadata, link} = this.props;

const videoId = getVideoId(link);
const videoTitle = metadata?.title || 'unknown';
const time = handleYoutubeTime(link);

const header = (
Expand All @@ -59,7 +60,7 @@ export default class YoutubeVideo extends React.PureComponent<Props, State> {
href={this.props.link}
location='youtube_video'
>
{metadata?.title || 'unknown'}
{videoTitle}
</ExternalLink>
</span>
</h4>
Expand All @@ -75,6 +76,10 @@ export default class YoutubeVideo extends React.PureComponent<Props, State> {
height='360px'
frameBorder='0'
allowFullScreen={true}
allow='accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share'
referrerPolicy='strict-origin-when-cross-origin'
title={videoTitle}
sandbox='allow-scripts allow-same-origin allow-popups allow-presentation'
/>
);
} else {
Expand Down