Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove t and localizeMessage from components/activity_log_modal #26987

Merged
merged 2 commits into from
May 13, 2024
Merged

Remove t and localizeMessage from components/activity_log_modal #26987

merged 2 commits into from
May 13, 2024

Commits on May 9, 2024

  1. Remove t from components/activity_log_modal

    @hmhealey
    hmhealey committed May 9, 2024
    Configuration menu
    Copy the full SHA
    8893163 View commit details
    Browse the repository at this point in the history

  2. Remove localizeMessage from components/activity_log_modal 

    I wanted to do more to simplify the various values we pass around for
icon, title, and text so that we'd just pass around a single "type"
value, but since this logic is weird, I gave up on that to focus on
localizeMessage and t.
    @hmhealey
    hmhealey committed May 9, 2024
    Configuration menu
    Copy the full SHA
    94a9100 View commit details
    Browse the repository at this point in the history