Centralize the GetPackagePath #27004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieut-data
added
2: Dev Review
mm-cloud-bot
added
the
release-note-none
As part of the change to [eliminate MM_SERVER_PATH](mattermost/enterprise#1676), I thought I had properly tested plugins relying on the server for tests, but apparently not, as these tests were now failing trying to resolve the `i18n` directory. To remedy this, and address feedback from the first PR, I've centralized a single `path.go` in the `server` root from which all other paths are built. The return value from this also gets added to the search paths for resolving asset directories at runtime. (Like `MM_SERVER_PATH` did before, but now unconditionally.)
lieut-data
force-pushed
the
single-root-server-path
branch
from
e8e5ced
to
556e7b3
Compare
|
/e2e-test |
|
E2E test triggered successfully for PR #27004, commit |
agnivade
approved these changes
May 15, 2024
wiggin77
approved these changes
May 15, 2024
There was a problem hiding this comment.
LGTM 👍 One thing that comes to mind that I should have included in the previous review... the GetPackagePath implementation may break if the place it is called from gets inlined. I think it's possible the result will be wrong if the inlined function is called from a different package.
|
Good call out, @wiggin77! I'll keep this in mind if we see unexpected breakage in the future. |
amyblais
added
Changelog/Not Needed
jwilander
added
the
kind/refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of the change to eliminate MM_SERVER_PATH, I thought I had properly tested plugins relying on the server for tests, but apparently not, as these tests were now failing trying to resolve the
i18ndirectory.To remedy this, and address feedback from the first PR, I've centralized a single
path.goin theserverroot from which all other paths are built. The return value from this also gets added to the search paths for resolving asset directories at runtime. (LikeMM_SERVER_PATHdid before, but now unconditionally.)Tested this time with the MS Teams plugin and can confirm the before and after effect of this PR.
Ticket Link
None.
Release Note