Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-57860 - Check user belongs to remote when Shared Channels updates a user profile image #27008

Merged
merged 1 commit into from
May 16, 2024

Conversation

wiggin77
Copy link
Member

Summary

This PR adds a check when updating remote user profile images to ensure the user belongs to the remote making the request.

Ticket Link

https://mattermost.atlassian.net/browse/MM-57860

Release Note

Check user belongs to remote when Shared Channels updates a user profile image

@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 15, 2024
@wiggin77 wiggin77 added 2: Dev Review Requires review by a developer 3: Security Review Review requested from Security Team labels May 15, 2024
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@jupenur jupenur removed the 3: Security Review Review requested from Security Team label May 16, 2024
@wiggin77 wiggin77 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels May 16, 2024
@wiggin77 wiggin77 merged commit 5a79565 into master May 16, 2024
41 checks passed
@wiggin77 wiggin77 deleted the MM-57860_profile_img_update_check_remoteid branch May 16, 2024 12:21
@amyblais
Copy link
Member

/cherry-pick release-9.9

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit that referenced this pull request May 16, 2024
@mattermost-build mattermost-build added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label May 16, 2024
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 16, 2024
@amyblais
Copy link
Member

/cherry-pick release-9.8

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@amyblais
Copy link
Member

/cherry-pick release-9.5

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants