Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MM-31911): duplicate option names cannot be selected in interactive … #27012

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erashu212
Copy link

@erashu212 erashu212 commented May 15, 2024

Summary

Duplicate option names cannot be selected in interactive dialogs. Follow the steps defined in JIRA ticket

Ticket Link

Fixes #26438
Jira https://mattermost.atlassian.net/browse/MM-31911

Screenshots

before after
Refer Jira Ticket Screenshot 2024-05-15 at 10 43 19 PM
Refer Jira Ticket Screenshot 2024-05-15 at 10 43 29 PM
Refer Jira Ticket Screenshot 2024-05-15 at 10 43 12 PM

Release Note

Added provision to show the option term as object so that the searching in auto complete can be performed on either label or value.

@mm-cloud-bot
Copy link

@erashu212: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @erashu212,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@erashu212
Copy link
Author

/check-cla

@erashu212 erashu212 changed the title fix(26438): duplicate option names cannot be selected in interactive … fix(MM-31911): duplicate option names cannot be selected in interactive … May 16, 2024
@mm-cloud-bot mm-cloud-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed labels May 19, 2024
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Lifecycle/1:stale release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate option names cannot be selected in interactive dialogs
3 participants