Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-58271] User Profile pop up | Make Call button appear Disabled when user is on active call #27020

Merged
merged 2 commits into from
May 18, 2024
Merged

[MM-58271] User Profile pop up | Make Call button appear Disabled when user is on active call #27020

merged 2 commits into from
May 18, 2024

Conversation

M-ZubairAhmed
Copy link
Member

@M-ZubairAhmed M-ZubairAhmed commented May 16, 2024 •
edited

Summary

  • Added disabled styling to the calls button
  • Wrapped it in WithTooltip component
  • Will be adding e2e in calls repo

Ticket Link

https://mattermost.atlassian.net/browse/MM-58271

Screenshots

CleanShot 2024-05-16 at 14 08 53

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 16, 2024
@M-ZubairAhmed M-ZubairAhmed requested a review from cpoile May 16, 2024 08:46
@M-ZubairAhmed M-ZubairAhmed added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 16, 2024
@unified-ci-app
Copy link
Contributor

Not triggering E2E tests: this PR has 9 commit status(es) or check-runs that are not passing. Ensure all statuses aside from the E2E testing ones are green, before triggering E2E tests.

@amyblais amyblais added this to the v9.10.0 milestone May 16, 2024
cpoile
cpoile approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zubair!

streamer45
streamer45 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We do have an e2e test for this, it just needs an extra check I think.

@streamer45 streamer45 removed the 2: Dev Review Requires review by a developer label May 17, 2024
@yasserfaraazkhan yasserfaraazkhan added the Setup Cloud Test Server Setup an on-prem test server label May 18, 2024
@M-ZubairAhmed M-ZubairAhmed merged commit cef7826 into master May 18, 2024
33 checks passed
@M-ZubairAhmed M-ZubairAhmed deleted the MM-58271 branch May 18, 2024 08:45
@mattermost-build mattermost-build removed the Setup Cloud Test Server Setup an on-prem test server label May 18, 2024
@mm-cloud-bot
Copy link

Test server destroyed

1 similar comment
@mm-cloud-bot
Copy link

Test server destroyed

@M-ZubairAhmed M-ZubairAhmed added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 18, 2024
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpoile cpoile cpoile approved these changes

@streamer45 streamer45 streamer45 approved these changes

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
v9.10.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@M-ZubairAhmed @mm-cloud-bot @cpoile @streamer45 @yasserfaraazkhan @mattermost-build @amyblais