Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor UI fixes #27022

Merged
merged 4 commits into from
May 21, 2024
Merged

Minor UI fixes #27022

merged 4 commits into from
May 21, 2024

Conversation

asaadmahmood
Copy link
Contributor

Summary

MM-58170 - Updating remove license modal
MM-58211 - Updating color on sign up page url

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-58211
Jira https://mattermost.atlassian.net/browse/MM-58170

Screenshots

CleanShot 2024-05-16 at 16 47 35@2x
CleanShot 2024-05-16 at 16 47 46@2x

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 16, 2024
@asaadmahmood asaadmahmood added 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review 2: Dev Review Requires review by a developer labels May 16, 2024
@unified-ci-app
Copy link
Contributor

Not triggering E2E tests: this PR has 8 commit status(es) or check-runs that are not passing. Ensure all statuses aside from the E2E testing ones are green, before triggering E2E tests.

@yasserfaraazkhan yasserfaraazkhan added the Setup Cloud Test Server Setup an on-prem test server label May 18, 2024
@yasserfaraazkhan yasserfaraazkhan added Setup Cloud + CWS Test Server Setup a test server linked to the CWS test portal and removed Setup Cloud Test Server Setup an on-prem test server Setup Cloud + CWS Test Server Setup a test server linked to the CWS test portal labels May 21, 2024
@yasserfaraazkhan
Copy link
Contributor

/update-branch

@yasserfaraazkhan yasserfaraazkhan added the Setup Cloud Test Server Setup an on-prem test server label May 21, 2024
yasserfaraazkhan
yasserfaraazkhan approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working as expected
Screenshot 2024-05-21 at 11 11 03 AM
Screenshot 2024-05-21 at 11 10 41 AM

@asaadmahmood asaadmahmood merged commit 383bf9b into mattermost:master May 21, 2024
15 checks passed
@mattermost-build mattermost-build removed the Setup Cloud Test Server Setup an on-prem test server label May 21, 2024
@mm-cloud-bot
Copy link

Test server destroyed

@asaadmahmood asaadmahmood deleted the ui-fixes branch May 21, 2024 07:20
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes

@M-ZubairAhmed M-ZubairAhmed M-ZubairAhmed approved these changes

@harshilsharma63 harshilsharma63 harshilsharma63 approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@asaadmahmood @yasserfaraazkhan @mm-cloud-bot @M-ZubairAhmed @harshilsharma63 @mattermost-build @amyblais