Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ServiceSettings.MaximumPayloadSize to SystemConsole #27124

Merged
merged 2 commits into from
May 29, 2024
Merged

Add ServiceSettings.MaximumPayloadSize to SystemConsole #27124

merged 2 commits into from
May 29, 2024

Conversation

sbishel
Copy link
Member

@sbishel sbishel commented May 22, 2024

Summary

Adds the configuration setting ServiceSettings.MaximumPayloadSizeBytes to the Environment/Web Server system console page.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-55980

Screenshots

Screenshot 2024-05-22 at 11 04 04 AM

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 22, 2024
@sbishel sbishel changed the title Add ServiceSettings.MaximumPayloadSize to SystemCnosole Add ServiceSettings.MaximumPayloadSize to SystemConsole May 22, 2024
@sbishel sbishel added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 22, 2024
@sbishel sbishel marked this pull request as ready for review May 22, 2024 20:16
@unified-ci-app
Copy link
Contributor

E2E test triggered successfully for PR #27124. The corresponding commit's status check will be available shortly.

@github-actions GitHub Actions
Copy link

E2E test run is starting for commit 39560b1f76cd14c0cc84e5644a8d0598aa27759b.
You can check its progress by either:

@sbishel sbishel requested a review from lindy65 May 28, 2024 16:04
@sbishel sbishel removed the 2: Dev Review Requires review by a developer label May 28, 2024
@lindy65 lindy65 added Setup Cloud Test Server Setup an on-prem test server 4: Reviews Complete All reviewers have approved the pull request QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process) and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Setup Cloud Test Server Setup an on-prem test server labels May 29, 2024
@mm-cloud-bot
Copy link

Test server destroyed

lindy65
lindy65 approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbishel - looks good to me 👍

@sbishel sbishel merged commit b0984be into mattermost:master May 29, 2024
17 checks passed
@sbishel sbishel deleted the MM-55980-SystemConsole-Payload branch May 29, 2024 15:06
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgdelacroix mgdelacroix mgdelacroix approved these changes

@calebroseland calebroseland calebroseland approved these changes

@lindy65 lindy65 lindy65 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process) release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sbishel @mm-cloud-bot @mgdelacroix @calebroseland @lindy65 @amyblais