MM-57319 Direct Message modal message improvement #27217

bruno-keiko · 2024-05-31T08:00:06Z

Summary

Issue #27175. In the Direct Message modal, once the user selects 7 members, the help text below the field is updated to “You can't add more than 7 people. Please create a channel to include more people.” The text ‘create a channel’ is a link and clicking on it dismisses this modal and triggers the Create channel modal.

Ticket Link

Fixes #27175
https://mattermost.atlassian.net/browse/MM-57319

Screenshots

Before:

After:

Release Note

UI change. Direct message modals help text changed

Updated help text in Direct Messages modal

*Help text changed, create a modal link created

mm-cloud-bot · 2024-05-31T08:00:08Z

@begench-g: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

mattermost-build · 2024-05-31T08:00:09Z

Hello @begench-g,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

bruno-keiko · 2024-05-31T08:38:09Z

/check-cla

larkox

Great job. A few changes.

server/config.mk

webapp/channels/src/components/more_direct_channels/list/index.ts

webapp/channels/src/components/more_direct_channels/list/list.tsx

webapp/channels/src/i18n/en.json

unified-ci-app · 2024-05-31T09:09:28Z

Not triggering E2E tests: this PR has 1 commit status(es) or check-runs that are not passing. Ensure all statuses aside from the E2E testing ones are green, before triggering E2E tests.

…component by using useDispatch hook.

bruno-keiko · 2024-05-31T10:37:55Z

Great job. A few changes.

Hello @larkox. Can you review it again? I fixed. Thank you for the review!

webapp/channels/src/components/more_direct_channels/list/list.scss

webapp/channels/src/components/more_direct_channels/list/list.tsx

larkox · 2024-06-13T14:04:57Z

@begench-g There are several style changes that seem unneeded specially in list.tsx, which make the review quite complicated to track what actually changed. Do you mind reverting the pure stylistic changes?

hmhealey

Thanks for the PR!

As mentioned above, would you mind reverting the stylistic changes here? I assume your editor did them automatically since they look like the changes Prettier makes.

Also, could you fix the broken unit tests like I mentioned on our community server?

webapp/channels/src/components/more_direct_channels/list/list.tsx

larkox

One minor change more.

webapp/channels/src/components/more_direct_channels/list/list.tsx

larkox · 2024-06-14T10:30:13Z

webapp/channels/src/components/more_direct_channels/list/list.tsx

+        remainingText = (
+            <FormattedMessage
+                id={'multiselect.maxPeople'}
+                defaultMessage={'Use ↑↓ to browse, ↵ to select. You can\'t add more than 7 people. Please <a>create a channel</a> to include more people.'}


Sorry for all the back and forth. Can you make one small change more? I don't expect we ever change the value of MAX_SELECTABLE_VALUES, but just in case, change the 7 here for a variable ({num} instead of 7) and pass it directly the MAX_SELECTABLE_VALUES in the values. That way, if we ever change it, we don't need to update the translations.

I completed the task, but I found another bug. When I try to close the direct message modal using dispatch, I can't find a way to do it; so I used props instead. However, this approach failed in testing.

@hmhealey Any idea why dispatch may fail here?

Because the "show" state of the MoreDirectChannels modal is in the component, not in the global store.

I'd assume that it's because the modal's identifier is different than the one it was opened with. This way of closing the modal is actually preferable though because it's a bit simpler. The only reason you should really need to dispatch closeModal is if something outside of the modal can close it

larkox

Thank you very much!

hmhealey

Thanks for making those changes. This looks good to me!

yasserfaraazkhan · 2024-06-19T11:22:57Z

/e2e-tests

unified-ci-app · 2024-06-19T11:23:03Z

Not triggering E2E tests: this PR has 2 commit status(es) or check-runs that are not passing. Ensure all statuses aside from the E2E testing ones are green, before triggering E2E tests.

yasserfaraazkhan · 2024-06-19T14:24:09Z

/update-branch

yasserfaraazkhan · 2024-06-20T07:01:42Z

@begench-g can you please check the CI failures?

bruno-keiko · 2024-06-21T04:21:32Z

@begench-g can you please check the CI failures?

I made updates to the snapshot test and it passed the CI test.

mm-cloud-bot · 2024-06-24T08:54:59Z

Test server destroyed

Direct Message modal message improvement

867d4b7

*Help text changed, create a modal link created

mm-cloud-bot added the do-not-merge/release-note-label-needed label May 31, 2024

mattermost-build added the Contributor label May 31, 2024

larkox requested changes May 31, 2024

View reviewed changes

larkox requested a review from hmhealey May 31, 2024 09:08

larkox added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 31, 2024

Begench added 3 commits May 31, 2024 15:01

Updated the use of openModal to directly handle state updates in the …

6920e96

…component by using useDispatch hook.

FormattedMessage is used in DM modal help text

4a8f337

MM_NO_DOCKER updated to true in /server/config.mk file

b1a73dc

larkox requested changes May 31, 2024

View reviewed changes

webapp/channels/src/components/more_direct_channels/list/list.scss Outdated Show resolved Hide resolved

webapp/channels/src/components/more_direct_channels/list/list.tsx Outdated Show resolved Hide resolved

DM modal help message bug fixed

e382505

larkox reviewed May 31, 2024

View reviewed changes

webapp/channels/src/components/more_direct_channels/list/list.tsx Outdated Show resolved Hide resolved

bug: remainingRext function changed to RemainingComponent

44fc514

hmhealey requested a review from larkox June 13, 2024 13:51

hmhealey changed the title ~~MM-27175 Direct Message modal message improvement~~ MM-57319 Direct Message modal message improvement Jun 13, 2024

mm-cloud-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed labels Jun 13, 2024

hmhealey requested changes Jun 13, 2024

View reviewed changes

webapp/channels/src/components/more_direct_channels/list/list.tsx Outdated Show resolved Hide resolved

webapp/channels/src/components/more_direct_channels/list/list.tsx Outdated Show resolved Hide resolved

Begench added 5 commits June 14, 2024 10:49

code style changes

bd433ce

code style changes

d33698f

code style changes

851a7a3

code style changes

af8fabf

code style changes

09b6d9d

larkox requested changes Jun 14, 2024

View reviewed changes

webapp/channels/src/components/more_direct_channels/list/list.tsx Outdated Show resolved Hide resolved

remaining text changed

7098135

larkox requested changes Jun 14, 2024

View reviewed changes

Begench added 3 commits June 14, 2024 17:37

fixed bug

8514b32

MM_NO_DOCKER ?= false

f74493a

MM_NO_DOCKER ?= false

8a2becd

larkox approved these changes Jun 14, 2024

View reviewed changes

hmhealey approved these changes Jun 18, 2024

View reviewed changes

hmhealey requested a review from yasserfaraazkhan June 18, 2024 20:51

hmhealey removed the 2: Dev Review Requires review by a developer label Jun 18, 2024

Merge branch 'master' into DM-modal-message-improvement

1e7fadc

yasserfaraazkhan added the Setup Cloud Test Server Setup an on-prem test server label Jun 20, 2024

yasserfaraazkhan removed the Setup Cloud Test Server Setup an on-prem test server label Jun 20, 2024

Begench added 2 commits June 20, 2024 19:54

added missed semicolons

f824d6f

snapshot updated

8aeec89

yasserfaraazkhan added the Setup Cloud Test Server Setup an on-prem test server label Jun 24, 2024

yasserfaraazkhan approved these changes Jun 24, 2024

View reviewed changes

larkox added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Jun 24, 2024

larkox merged commit 06f5953 into mattermost:master Jun 24, 2024
16 checks passed

mattermost-build removed the Setup Cloud Test Server Setup an on-prem test server label Jun 24, 2024

amyblais added Docs/Needed Requires documentation Changelog/Done Required changelog entry has been written labels Jun 24, 2024

amyblais added this to the v9.11.0 milestone Jun 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MM-57319 Direct Message modal message improvement #27217

MM-57319 Direct Message modal message improvement #27217

bruno-keiko commented May 31, 2024 •

edited by hmhealey

Loading

mm-cloud-bot commented May 31, 2024

mattermost-build commented May 31, 2024

bruno-keiko commented May 31, 2024

larkox left a comment

unified-ci-app bot commented May 31, 2024

bruno-keiko commented May 31, 2024

larkox commented Jun 13, 2024

hmhealey left a comment

larkox left a comment

larkox Jun 14, 2024

bruno-keiko Jun 14, 2024

larkox Jun 14, 2024

bruno-keiko Jun 17, 2024

hmhealey Jun 18, 2024

larkox left a comment

hmhealey left a comment

yasserfaraazkhan commented Jun 19, 2024

unified-ci-app bot commented Jun 19, 2024

yasserfaraazkhan commented Jun 19, 2024

yasserfaraazkhan commented Jun 20, 2024

bruno-keiko commented Jun 21, 2024

mm-cloud-bot commented Jun 24, 2024

MM-57319 Direct Message modal message improvement #27217

MM-57319 Direct Message modal message improvement #27217

Conversation

bruno-keiko commented May 31, 2024 • edited by hmhealey Loading

Summary

Ticket Link

Screenshots

Release Note

mm-cloud-bot commented May 31, 2024

mattermost-build commented May 31, 2024

bruno-keiko commented May 31, 2024

larkox left a comment

Choose a reason for hiding this comment

unified-ci-app bot commented May 31, 2024

bruno-keiko commented May 31, 2024

larkox commented Jun 13, 2024

hmhealey left a comment

Choose a reason for hiding this comment

larkox left a comment

Choose a reason for hiding this comment

larkox Jun 14, 2024

Choose a reason for hiding this comment

bruno-keiko Jun 14, 2024

Choose a reason for hiding this comment

larkox Jun 14, 2024

Choose a reason for hiding this comment

bruno-keiko Jun 17, 2024

Choose a reason for hiding this comment

hmhealey Jun 18, 2024

Choose a reason for hiding this comment

larkox left a comment

Choose a reason for hiding this comment

hmhealey left a comment

Choose a reason for hiding this comment

yasserfaraazkhan commented Jun 19, 2024

unified-ci-app bot commented Jun 19, 2024

yasserfaraazkhan commented Jun 19, 2024

yasserfaraazkhan commented Jun 20, 2024

bruno-keiko commented Jun 21, 2024

mm-cloud-bot commented Jun 24, 2024

bruno-keiko commented May 31, 2024 •

edited by hmhealey

Loading