Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-58512] Migrate tooltips of "components/status_dropdown/status_dropdown.tsx" to WithTooltip #27246

Merged
merged 3 commits into from
Jun 25, 2024
Merged

[MM-58512] Migrate tooltips of "components/status_dropdown/status_dropdown.tsx" to WithTooltip #27246

merged 3 commits into from
Jun 25, 2024

Conversation

Aryakoste
Copy link
Contributor

Summary

Ticket Link

Fixes #27234
Jira https://mattermost.atlassian.net/browse/MM-58512

Screenshots

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 2, 2024
@mattermost-build
Copy link
Contributor

Hello @Aryakoste,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@M-ZubairAhmed
Copy link
Member

/update-branch

@M-ZubairAhmed M-ZubairAhmed added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review and removed Lifecycle/1:stale labels Jun 19, 2024
@unified-ci-app
Copy link
Contributor

Not triggering E2E tests: this PR has 8 commit status(es) or check-runs that are not passing. Ensure all statuses aside from the E2E testing ones are green, before triggering E2E tests.

@M-ZubairAhmed M-ZubairAhmed self-requested a review June 19, 2024 12:32
@M-ZubairAhmed M-ZubairAhmed changed the title Tooltips to WithTooltip status_dropdown.tsx [MM-58512] Migrate tooltips of "components/status_dropdown/status_dropdown.tsx" to WithTooltip Jun 19, 2024
@M-ZubairAhmed
Copy link
Member

@Aryakoste can you look at the failing CI

@Aryakoste Aryakoste force-pushed the MM-58512_tooltips-to-WithTooltip-status_dropdown.tsx branch from a4f594f to e62a4b4 Compare June 19, 2024 18:27
@Aryakoste
Copy link
Contributor Author

/update-branch

M-ZubairAhmed
M-ZubairAhmed approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@M-ZubairAhmed M-ZubairAhmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :shipit: Thank you

@yasserfaraazkhan
Copy link
Contributor

/e2e-tests

@unified-ci-app
Copy link
Contributor

E2E test triggered successfully for PR #27246. The corresponding commit's status check will be available shortly.

@github-actions GitHub Actions
Copy link

E2E test run is starting for commit 8436bfe46bcdbeacb7cdde1623fc2938904d1f85.
You can check its progress by either:

@yasserfaraazkhan yasserfaraazkhan added the Setup Cloud Test Server Setup an on-prem test server label Jun 24, 2024
@M-ZubairAhmed M-ZubairAhmed removed the request for review from sinansonmez June 25, 2024 07:01
@M-ZubairAhmed M-ZubairAhmed removed 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Setup Cloud Test Server Setup an on-prem test server labels Jun 25, 2024
@M-ZubairAhmed M-ZubairAhmed added the 4: Reviews Complete All reviewers have approved the pull request label Jun 25, 2024
@mm-cloud-bot
Copy link

Test server destroyed

@M-ZubairAhmed M-ZubairAhmed merged commit 926c7ae into mattermost:master Jun 25, 2024
16 checks passed
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jun 25, 2024
@jwilander jwilander added the kind/refactor Categorizes issue or PR as related to refactor of production code. label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes

@M-ZubairAhmed M-ZubairAhmed M-ZubairAhmed approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Contributor Docs/Not Needed Does not require documentation kind/refactor Categorizes issue or PR as related to refactor of production code. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate tooltips of "components/status_dropdown/status_dropdown.tsx" to WithTooltip
7 participants
@Aryakoste @mattermost-build @M-ZubairAhmed @yasserfaraazkhan @mm-cloud-bot @jwilander @amyblais