Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-58515] Migrate tooltips of "components/shared_channel_indicator.tsx" to WithTooltip #27247

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Aryakoste
Copy link
Contributor

Summary

Ticket Link

Fixes #27231
Jira https://mattermost.atlassian.net/browse/MM-58515

Screenshots

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 2, 2024
@mattermost-build
Copy link
Contributor

Hello @Aryakoste,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@M-ZubairAhmed M-ZubairAhmed added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review and removed Lifecycle/1:stale labels Jun 19, 2024
@M-ZubairAhmed
Copy link
Member

/update-branch

@unified-ci-app
Copy link
Contributor

E2E test triggered successfully for PR #27247. The corresponding commit's status check will be available shortly.

Copy link

E2E test run is starting for commit 6f5c77e11e8eef4fae4ecd6a09227267c2abbe6f.
You can check its progress by either:

@M-ZubairAhmed M-ZubairAhmed self-requested a review June 19, 2024 12:32
@M-ZubairAhmed M-ZubairAhmed changed the title Tooltips to WithTooltip shared_channel_indicator.tsx [MM-58515] Migrate tooltips of "components/shared_channel_indicator.tsx" to WithTooltip Jun 19, 2024
@M-ZubairAhmed
Copy link
Member

@Aryakoste can you please check ci failures

@M-ZubairAhmed
Copy link
Member

@Aryakoste hows it going with this?

@M-ZubairAhmed
Copy link
Member

@Aryakoste can you check the failing CI ?

@M-ZubairAhmed M-ZubairAhmed requested review from Rajat-Dabade and removed request for sinansonmez June 25, 2024 12:33
@M-ZubairAhmed
Copy link
Member

/update-branch

Copy link
Member

@M-ZubairAhmed M-ZubairAhmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :shipit: Thank you

@M-ZubairAhmed M-ZubairAhmed added the Setup Cloud Test Server Setup an on-prem test server label Jun 26, 2024
@mm-cloud-bot
Copy link

Creating a new SpinWick test server using Mattermost Cloud.

@mm-cloud-bot
Copy link

Mattermost test server created! 🎉

Access here: https://mattermost-pr-27247.test.mattermost.cloud

Account Type Username Password
Admin sysadmin Sys@dmin123
User user-1 User-1@123

Your Spinwick's installation ID is: bs1dh5566frjjpjg818tcnp4mw
To access the logs, please click here

@yasserfaraazkhan
Copy link
Contributor

@M-ZubairAhmed is there a setup required to view shared channel?
can you help with the setup?

@M-ZubairAhmed
Copy link
Member

@M-ZubairAhmed is there a setup required to view shared channel? can you help with the setup?

Yes there is here is the docs https://docs.mattermost.com/onboard/shared-channels.html#set-up-shared-channels

@yasserfaraazkhan
Copy link
Contributor

yasserfaraazkhan commented Jun 26, 2024

@M-ZubairAhmed I've tried this, but see it not working. Can you please set it up for QA?

QA waiting for Setup to be done.

Screenshot 2024-06-26 200246

Screenshot 2024-06-26 200127

@yasserfaraazkhan yasserfaraazkhan removed the 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review label Jun 26, 2024
@yasserfaraazkhan yasserfaraazkhan removed their request for review June 26, 2024 14:35
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a developer Contributor Lifecycle/1:stale release-note-none Denotes a PR that doesn't merit a release note. Setup Cloud Test Server Setup an on-prem test server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate tooltips of "components/shared_channel_indicator.tsx" to WithTooltip
6 participants