Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-58519] Migrate tooltips of "components/integrations/bots/add_bot/add_bot.tsx" to WithTooltip #27291

Conversation

Aryakoste
Copy link
Contributor

Summary

Ticket Link

Fixes #27227
Jira https://mattermost.atlassian.net/browse/MM-58519

Screenshots

Release Note

NONE

@mattermost-build
Copy link
Contributor

Hello @Aryakoste,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 5, 2024
Copy link
Contributor

@pvev pvev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @Aryakoste 🚀 the change looks good to me 👍

@pvev pvev added the 2: Dev Review Requires review by a developer label Jun 7, 2024
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@M-ZubairAhmed M-ZubairAhmed added 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review and removed Lifecycle/1:stale labels Jun 19, 2024
@unified-ci-app
Copy link
Contributor

Not triggering E2E tests: this PR has 8 commit status(es) or check-runs that are not passing. Ensure all statuses aside from the E2E testing ones are green, before triggering E2E tests.

@M-ZubairAhmed
Copy link
Member

/update-branch

@M-ZubairAhmed M-ZubairAhmed changed the title Tooltips to WithTooltip add_bot.tsx [MM-58519] Migrate tooltips of "components/integrations/bots/add_bot/add_bot.tsx" to WithTooltip Jun 19, 2024
@M-ZubairAhmed M-ZubairAhmed removed the 2: Dev Review Requires review by a developer label Jun 19, 2024
@yasserfaraazkhan yasserfaraazkhan added the Setup Cloud Test Server Setup an on-prem test server label Jun 19, 2024
@yasserfaraazkhan
Copy link
Contributor

/e2e-tests

@unified-ci-app
Copy link
Contributor

E2E test triggered successfully for PR #27291. The corresponding commit's status check will be available shortly.

Copy link

E2E test run is starting for commit f32a40e03e4ef0f6fa2ce8e414902f6cb58773ed.
You can check its progress by either:

@M-ZubairAhmed M-ZubairAhmed added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Setup Cloud Test Server Setup an on-prem test server labels Jun 20, 2024
@mm-cloud-bot
Copy link

Test server destroyed

@M-ZubairAhmed M-ZubairAhmed merged commit 09792ae into mattermost:master Jun 20, 2024
16 checks passed
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Contributor Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate tooltips of "components/integrations/bots/add_bot/add_bot.tsx" to WithTooltip
7 participants