Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-3427 Added channel header to view channel info modal #3584

Merged
merged 1 commit into from
Jul 14, 2016

Conversation

DavidLu1997
Copy link
Contributor

Summary

Added channel header (with markdown formatting) to the view channel info modal.
Also removed Purpose and Header displays if they do not exist.

Ticket Link

https://mattermost.atlassian.net/browse/PLT-3427
#3563 (discussion)

Checklist

[Place an '[x]' (no spaces) in all applicable fields.]

  • Added or updated unit tests (required for all new features)
  • Added API documentation (required for all new APIs)
  • Has driver changes that have been merged and package.json updated
  • Has enterprise changes (please link)
  • Has UI changes
  • Includes text changes and localization files updated
  • Touches critical sections of the codebase (auth, upgrade, etc.)

@enahum enahum added 2: Dev Review Requires review by a developer 1: PM Review Requires review by a product manager labels Jul 13, 2016
@enahum
Copy link
Contributor

enahum commented Jul 13, 2016

+1

Added label on PM Approval cause of discussion in #3534

@crspeller
Copy link
Member

+1

@crspeller crspeller removed the 2: Dev Review Requires review by a developer label Jul 14, 2016
@mattermod
Copy link
Contributor

Spinmint test server being created...

@esethna esethna added the Setup Old Test Server Triggers the creation of a test server label Jul 14, 2016
@mattermod
Copy link
Contributor

Spinmint test server created.

Link: http://i-319461a5.spinmint.com:8065/pr3584

Email: test@test.com

Email2: test2@test.com

Password: passwd

Instance ID: i-319461a5

@esethna
Copy link
Contributor

esethna commented Jul 14, 2016

Hey @DavidLu1997, tested, looks good, I I just want to make sure that this change does not cause previously set channel headers to be reset?

Tested in private groups and public channels:

  1. Long headers (view info modal will scroll)
  2. adding and removing headers and purpose
  3. links, headings, bold, numbers, lists, inline images

@mattermod
Copy link
Contributor

Spinmint test server destroyed

@esethna esethna removed 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Jul 14, 2016
@crspeller crspeller added the Awaiting Submitter Action Blocked on the author label Jul 14, 2016
@DavidLu1997
Copy link
Contributor Author

@esethna this PR does not affect previously set channel headers to reset, it only displays them.

@esethna
Copy link
Contributor

esethna commented Jul 14, 2016

Great, thanks!

@esethna esethna removed the Awaiting Submitter Action Blocked on the author label Jul 14, 2016
@coreyhulen coreyhulen merged commit bd12520 into mattermost:master Jul 14, 2016
@DavidLu1997 DavidLu1997 deleted the plt-3427 branch August 3, 2016 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants