More app code migration #5170
Merged
More app code migration #5170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crspeller
approved these changes
Jan 25, 2017
jwilander
force-pushed
the
app-code-migration3
branch
from
ab0b932
to
ca6e2e1
Compare
coreyhulen
approved these changes
Jan 25, 2017
coreyhulen
added
4: Reviews Complete
debanshuk
pushed a commit
to debanshuk/platform
that referenced
this pull request
Feb 5, 2017
… which doens't exist. This error is a side effect of changes done in PR mattermost#5181. In this PR logic to close response was added. But in cases when some error occures while getting the response, function to close response should not be called, as response is null in those cases. Moreover, error was only occuring on the server and wasn't causing any error on the client until refactoring of code was done in PR mattermost#5170.
debanshuk
pushed a commit
to debanshuk/platform
that referenced
this pull request
Feb 5, 2017
… which doens't exist. This error was a side effect of changes done in PR mattermost#5181. In this PR logic to close response was added. But in cases when some error occurs while getting the response, function to close response should not be called, as response is null in those cases. Moreover, error was only occurring on the server and wasn't causing any error on the client until refactoring of code was done in PR mattermost#5170.
debanshuk
pushed a commit
to debanshuk/platform
that referenced
this pull request
Feb 5, 2017
…which don't exist. This error was a side effect of changes done in PR mattermost#5181. In this PR logic to close response was added. But in cases when some error occurs while getting the response, function to close response should not be called, as response is null in those cases. Moreover, error was only occurring on the server and wasn't causing any error on the client until refactoring of code was done in PR mattermost#5170.
debanshuk
pushed a commit
to debanshuk/platform
that referenced
this pull request
Feb 6, 2017
…which don't exist. This error was a side effect of changes done in PR mattermost#5181. In this PR logic to close response was added. But in cases when some error occurs while getting the response, function to close response should not be called, as response is null in those cases. Moreover, the error was only occurring on the server and wasn't causing any error on the client until refactoring of code was done in PR mattermost#5170.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mostly just migrating functions, probably easier to review commit by commit.
Checklist