Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-5281 Add link to team URL error #5270

Merged
merged 1 commit into from
Feb 2, 2017

Conversation

DavidLu1997
Copy link
Contributor

Summary

Adds a link to the error message shown when a team name may contain a reserved word.

Ticket Link

PLT-5281

Checklist

  • Includes text changes and localization file

@grundleborg grundleborg added the 2: Dev Review Requires review by a developer label Feb 2, 2017
@coreyhulen coreyhulen merged commit 60be5c9 into mattermost:master Feb 2, 2017
@DavidLu1997 DavidLu1997 deleted the plt-5281 branch February 2, 2017 17:42
@jasonblais
Copy link
Contributor

Thanks @DavidLu1997! :)

Looks like the link in the error text isn't clickable, although it's highlighted as one.

image

@jasonblais
Copy link
Contributor

@DavidLu1997 would you have time making the starts with a reserved word URL highlighted above clickable, like a regular link?

@DavidLu1997
Copy link
Contributor Author

@jasonblais Sorry, I didn't see this until now. I'll try something by Monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants