Adding ability to remove push ids when reported as removed from google or apple #5513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m google or apple
coreyhulen
changed the title
coreyhulen
added
Work In Progress
enahum
approved these changes
Feb 23, 2017
jwilander
reviewed
Feb 23, 2017
app/notification.go
Outdated
| resp.Body.Close() | ||
| } | ||
|
|
||
| if m != nil && m[model.STATUS] == model.STATUS_REMOVE { |
There was a problem hiding this comment.
Minor, but unneeded nil check since MapFromJson always returns a valid map. Left up to your discretion as to whether or not to remove
crspeller
approved these changes
Feb 24, 2017
andreistanciu24
pushed a commit
to andreistanciu24/platform
that referenced
this pull request
Feb 27, 2017
…e or apple (mattermost#5513) * Adding ability to remove push device Ids when reported as removed from google or apple * Fixing log string * Removing unneeded nil check
andreistanciu24
pushed a commit
to andreistanciu24/platform
that referenced
this pull request
Feb 28, 2017
…e or apple (mattermost#5513) * Adding ability to remove push device Ids when reported as removed from google or apple * Fixing log string * Removing unneeded nil check
andreistanciu24
pushed a commit
to andreistanciu24/platform
that referenced
this pull request
Feb 28, 2017
…e or apple (mattermost#5513) * Adding ability to remove push device Ids when reported as removed from google or apple * Fixing log string * Removing unneeded nil check
andreistanciu24
pushed a commit
to andreistanciu24/platform
that referenced
this pull request
Mar 2, 2017
…e or apple (mattermost#5513) * Adding ability to remove push device Ids when reported as removed from google or apple * Fixing log string * Removing unneeded nil check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the ability to remove device IDs when the APNS reports the ID as invalid.
Ticket Link
https://mattermost.atlassian.net/browse/PLT-4427
Checklist