Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLT-5585] Save Recently Used Emojis After Logout #5926

Merged
merged 1 commit into from
Apr 4, 2017
Merged

[PLT-5585] Save Recently Used Emojis After Logout #5926

merged 1 commit into from
Apr 4, 2017

Conversation

ry-wang
Copy link
Contributor

@ry-wang ry-wang commented Mar 31, 2017

Summary

The Recently Used emojis will now persist after the user logs out and back in.

Ticket Link

https://mattermost.atlassian.net/browse/PLT-5585

@jasonblais jasonblais added 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Mar 31, 2017
@mattermod
Copy link
Contributor

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

@mattermod
Copy link
Contributor

Spinmint test server created at: http://i-0158bcc58ccf79577.spinmint.com:8065/pr5926

Test Account 1: Email: test@test.com | Password: passwd

Test Account 2: Email: test2@test.com | Password: passwd

Instance ID: i-0158bcc58ccf79577

@esethna esethna added this to the v3.9.0 milestone Mar 31, 2017
@esethna
Copy link
Contributor

esethna commented Mar 31, 2017

Thanks @R-Wang97, appreciate the pull request! Just letting you know that there may be a delay in reviewing and merging your PR since we are approaching code complete for v3.8, releasing April 16th. Please see our release process for more details.

@jasonblais jasonblais self-assigned this Mar 31, 2017
jasonblais
jasonblais approved these changes Apr 1, 2017
View reviewed changes
Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @R-Wang97, great work here. Tested and didn't find issues.

@jasonblais jasonblais added 2: Dev Review Requires review by a developer and removed 1: PM Review Requires review by a product manager labels Apr 1, 2017
@jasonblais jasonblais removed their assignment Apr 1, 2017
jwilander
jwilander requested changes Apr 3, 2017
View reviewed changes
webapp/utils/constants.jsx Outdated
@@ -894,6 +894,9 @@ export const Constants = {
MIN_HASHTAG_LINK_LENGTH: 3,
CHANNEL_SCROLL_ADJUSTMENT: 100,
EMOJI_PATH: '/static/emoji',
CHANGE_EVENT: 'changed',
RECENT_EMOJI_KEY: 'recentEmojis',
MAXIMUM_RECENT_EMOJI: 27,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the constants only used in one file, can we keep them in that file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll move CHANGE_EVENT and MAXIMUM_RECENT_EMOJI back to emoji_store.jsx.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @R-Wang97! If you have time to submit the update by early Tuesday, we should be able to take this one for the next Mattermost release (3.8)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonblais Updates made!

@esethna esethna modified the milestones: v3.8.0, v3.9.0 Apr 3, 2017
@esethna esethna removed the Setup Old Test Server Triggers the creation of a test server label Apr 3, 2017
@jwilander jwilander added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Apr 4, 2017
@mattermod
Copy link
Contributor

Spinmint test server destroyed

@jwilander jwilander merged commit 169c490 into mattermost:master Apr 4, 2017
@ry-wang ry-wang deleted the PLT-5585 branch April 4, 2017 14:05
@lindalumitchell lindalumitchell added the Tests/Done Required release tests have been written label Apr 4, 2017
@jasonblais jasonblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonblais jasonblais jasonblais approved these changes

@coreyhulen coreyhulen coreyhulen approved these changes

@jwilander jwilander jwilander approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Required release tests have been written
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ry-wang @mattermod @esethna @coreyhulen @jwilander @jasonblais @lindalumitchell