Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating unit tests for diagnostics #5932

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Creating unit tests for diagnostics #5932

merged 1 commit into from
Apr 3, 2017

Conversation

crspeller
Copy link
Member

No description provided.

@crspeller crspeller added the 2: Dev Review Requires review by a developer label Mar 31, 2017
grundleborg
grundleborg approved these changes Apr 3, 2017
View reviewed changes
Copy link
Contributor

@grundleborg grundleborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grundleborg grundleborg merged commit 67a8770 into master Apr 3, 2017
@grundleborg grundleborg deleted the update-diagnostics-tests branch April 3, 2017 11:01
@jasonblais jasonblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed New release tests not required labels Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grundleborg grundleborg grundleborg approved these changes

@jwilander jwilander jwilander approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a developer Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed New release tests not required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crspeller @grundleborg @jwilander @jasonblais