PLT-27 Implement incoming webhooks. #715
Conversation
|
@jwilander Needs rebase |
| return | ||
| } | ||
|
|
||
| c.LogAudit("attempt") |
There was a problem hiding this comment.
Was this intended to be left in? It looks like a debug statement.
There was a problem hiding this comment.
Intended. We log an audit when we receive an attempt to create an incoming webhook since once the webhook is created, whoever has it can post as that user. We do audit logs like this in multiple places as well (usually for password related or user modifying related stuff)
| @@ -24,7 +24,8 @@ | |||
| "StorageDirectory": "/mattermost/data/", | |||
| "AllowedLoginAttempts": 10, | |||
| "DisableEmailSignUp": false, | |||
| "EnableOAuthServiceProvider": false | |||
| "EnableOAuthServiceProvider": false, | |||
| "AllowIncomingWebhooks": false | |||
There was a problem hiding this comment.
Maybe we should allow webhooks in the preview instances to show them off?
There was a problem hiding this comment.
That's the plan but I was going to wait until Asaad's UI changes before turning it on by default
|
Looks good to me, but I'll let Chris pass judgment as the seconder since he had a few issues with it that I missed. |
|
+1 Other than the one thing for @coreyhulen |
| c.Err.StatusCode = http.StatusNotImplemented | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe add audit attempt/success for delete
|
@jwilander this is ready correct? +1 from me. |
|
@coreyhulen yes it's ready |
PLT-27 Implement incoming webhooks.
This PR does the following:
I also edited the config.