Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "disable EnablePublicChannelsMaterialization by default (#9418)" #9427

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

lieut-data
Copy link
Member

Summary

This reverts commit 5786b0d, now that
the feature is safe to enable by default.

Ticket Link

None.

This reverts commit 5786b0d, now that
the feature is safe to enable by default.
@lieut-data lieut-data added Work In Progress Not yet ready for review 2: Dev Review Requires review by a developer and removed Work In Progress Not yet ready for review labels Sep 17, 2018
@lieut-data
Copy link
Member Author

Testing on ci-linux-mysql (manually enabled via config change) looks good.

@jwilander jwilander added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Sep 18, 2018
@jwilander jwilander merged commit 0204c45 into master Sep 18, 2018
@jwilander jwilander deleted the reenable-materialize-public-channels branch September 18, 2018 14:53
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 18, 2018
@DHaussermann
Copy link

As per dev, Testing done as part of https://mattermost.atlassian.net/browse/MM-11947

Adding label

@DHaussermann DHaussermann added the Tests/Done Required release tests have been written label Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Required release tests have been written
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants